-
Notifications
You must be signed in to change notification settings - Fork 8
add experimental chain feature #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 poopoothegorilla, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
cmd/workflow/simulate/simulate.go
Outdated
|
|
||
| // Skip if chain ID already exists (supported chain takes precedence) | ||
| if _, exists := clients[ec.ChainID]; exists { | ||
| h.log.Debug().Uint64("chain-id", ec.ChainID).Msg("Experimental chain ID conflicts with supported chain; skipping") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if this is the right behaviour. They could have an on-chain contract that expects the old forwarder (in the event that it changed for any reason).
I would check if it's the same, if it is, then emit a debug, if it's not respect their wishes and emit a warning.
@wentzeld what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went ahead and put this in... we can always change if needed
timothyF95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
https://smartcontract-it.atlassian.net/browse/DEVSVCS-3734
$ ../cre workflow simulate ./my-workflow {"level":"info","chain-id":4801,"time":"2026-01-29T08:51:12-05:00","message":"Added experimental chain"} {"level":"info","chain-id":480,"time":"2026-01-29T08:51:12-05:00","message":"Added experimental chain"} Warning: using default private key for chain write simulation. To use your own key, set CRE_ETH_PRIVATE_KEY in your .env file or system environment. Workflow compiled 2026-01-29T08:51:14Z [SIMULATION] Simulator Initialized 2026-01-29T08:51:14Z [SIMULATION] Running trigger [email protected] 2026-01-29T08:51:14Z [USER LOG] msg="Cron trigger fired" scheduledTime=2026-01-29T13:51:14.709Z 2026-01-29T08:51:14Z [USER LOG] msg="Experimental chains available" worldchain-sepolia=4801 worldchain-mainnet=480 Workflow Simulation Result: { "Result": "Cron fired at 2026-01-29 13:51:14.709344 +0000 UTC" } 2026-01-29T08:51:14Z [SIMULATION] Execution finished signal received 2026-01-29T08:51:14Z [SIMULATION] Skipping WorkflowEngineV2