Open
Conversation
dsperling
requested changes
Aug 12, 2024
Member
dsperling
left a comment
There was a problem hiding this comment.
Adding workflows in welcome, but a few requests:
- This project is focused on small Docker images, but the build-time optimizations make the n7m app image larger. Can we back these changes out without impacting the workflow?
- We are splitting n7m-app into two images - n7m-api and n7m-feed. These changes will be merged soon and the workflow will need to be changed. See
feature/apibranch. - Could you recommend text for the README for developers to get this setup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15.
Add GitHub workflow to: