Force long output text to scroll#831
Open
bgmeulem wants to merge 3 commits intospatialaudio:masterfrom
Open
Conversation
Member
|
Thanks for this PR! I'm not sure if an unconditional fixed threshold is the right thing to do, though. The Jupyter Notebook has already "scrolled" metadata (see #372), so why not use this?
Why not use whatever the Jupyter Notebook uses? |
Member
|
If you want to avoid the (unrelated) CI errors (which I fixed in #835), you can rebase this PR. |
|
I personally like this simple solution. Yet it should not be merged. You can achieve the same using custom CSS: html_static_path = ["_static"]
html_css_files = [
"css/nbsphinx.css",
]/*nbsphinx.css*/
div.nboutput.container div.output_area:has(pre) {
max-height: 600px;
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, long cell output does not scroll. This has been adressed in issues #754 #417 and #372.
These cells are already correctly configured to scroll upon overflow from various parent classes.
The reason these outputs don't scroll vertically is simply because there is no limit on how much vertical space they are allowed to take, so they never overflow.
This PR simply implements a maximum height of
600pxfor allnboutput containerclasses, but only for those that contain text. I chose600pxrather arbitrarily, feel free to change to something more dynamic (don't forget to update docs as well then).Checking if they contain text is done by checking if they have a child with
pre. I'm not very accustomed to CSS, so I don't know if this is a good way to check.I also added an example for this in the docs.