Skip to content

Comments

Fixing details loading for datasets#256

Merged
klpoland merged 3 commits intomasterfrom
fix-kpoland-regression-testing-dataset-details-loading-issues
Feb 20, 2026
Merged

Fixing details loading for datasets#256
klpoland merged 3 commits intomasterfrom
fix-kpoland-regression-testing-dataset-details-loading-issues

Conversation

@klpoland
Copy link
Collaborator

@klpoland klpoland commented Feb 12, 2026

SFDS-308

In this PR:

  • Added test coverage for publishing, more specific details population tests (for owner and shared users), more specific sharing action tests
  • Remove redundant/conflicting dataset details loading flow
  • Add logic for finding files when user is not the owner (previously ONLY used sanitize_path_rel_to_user which assumes path is owned by user)

@klpoland klpoland requested a review from lucaspar February 12, 2026 15:21
@klpoland klpoland self-assigned this Feb 12, 2026
@klpoland klpoland added bug Something isn't working gateway Gateway component javascript Pull requests that update non-trivial javascript code labels Feb 12, 2026
@lucaspar lucaspar changed the title Fix kpoland regression testing dataset details loading issues Fixing details loading for datasets Feb 12, 2026
@lucaspar lucaspar requested a review from Copilot February 12, 2026 16:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes dataset details loading (especially for shared datasets) by updating server-side file tree base directory selection and refactoring client-side dataset modal loading, alongside expanded Jest test coverage for publish/sharing/details/download flows.

Changes:

  • Update dataset details endpoint to determine file-tree base directory differently for shared vs owned datasets.
  • Refactor DetailsActionManager to rely on Bootstrap modal show events for dataset details loading and remove redundant dataset-button handling.
  • Add/expand Jest setup and multiple new/updated tests (publish/share/details/download) and adjust coverage exclusions.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
gateway/sds_gateway/users/views.py Adjusts dataset details file-tree base directory logic for shared datasets.
gateway/sds_gateway/static/js/tests-config/jest.setup.js Makes window.location.href settable in tests without navigation.
gateway/sds_gateway/static/js/tests-config/jest.config.js Excludes deprecated/legacy JS files from coverage collection.
gateway/sds_gateway/static/js/share/tests/ShareGroupManager.test.js Adds tests for rendering shared-assets info (filter/sort/empty).
gateway/sds_gateway/static/js/actions/tests/ShareActionManager.test.js Adds more granular tests for searching/selecting users and sharing payloads.
gateway/sds_gateway/static/js/actions/tests/PublishActionManager.test.js Adds new tests for publish behavior and error handling.
gateway/sds_gateway/static/js/actions/tests/DownloadActionManager.test.js Improves dataset/capture download tests and DOMUtils mocking.
gateway/sds_gateway/static/js/actions/tests/DetailsActionManager.test.js Adds dataset modal loading tests for owner and shared viewers.
gateway/sds_gateway/static/js/actions/PublishActionManager.js Exposes PublishActionManager on window and via module.exports for Jest.
gateway/sds_gateway/static/js/actions/DetailsActionManager.js Removes dataset details button flow; loads dataset details on modal show; awaits async file-tree rendering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@klpoland klpoland force-pushed the fix-kpoland-regression-testing-dataset-details-loading-issues branch from 05b4192 to 92630fd Compare February 20, 2026 19:18
@klpoland klpoland merged commit d8c6e1d into master Feb 20, 2026
2 checks passed
@klpoland klpoland deleted the fix-kpoland-regression-testing-dataset-details-loading-issues branch February 20, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gateway Gateway component javascript Pull requests that update non-trivial javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants