Merged
Conversation
lucaspar
reviewed
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes dataset details loading (especially for shared datasets) by updating server-side file tree base directory selection and refactoring client-side dataset modal loading, alongside expanded Jest test coverage for publish/sharing/details/download flows.
Changes:
- Update dataset details endpoint to determine file-tree base directory differently for shared vs owned datasets.
- Refactor
DetailsActionManagerto rely on Bootstrap modal show events for dataset details loading and remove redundant dataset-button handling. - Add/expand Jest setup and multiple new/updated tests (publish/share/details/download) and adjust coverage exclusions.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gateway/sds_gateway/users/views.py | Adjusts dataset details file-tree base directory logic for shared datasets. |
| gateway/sds_gateway/static/js/tests-config/jest.setup.js | Makes window.location.href settable in tests without navigation. |
| gateway/sds_gateway/static/js/tests-config/jest.config.js | Excludes deprecated/legacy JS files from coverage collection. |
| gateway/sds_gateway/static/js/share/tests/ShareGroupManager.test.js | Adds tests for rendering shared-assets info (filter/sort/empty). |
| gateway/sds_gateway/static/js/actions/tests/ShareActionManager.test.js | Adds more granular tests for searching/selecting users and sharing payloads. |
| gateway/sds_gateway/static/js/actions/tests/PublishActionManager.test.js | Adds new tests for publish behavior and error handling. |
| gateway/sds_gateway/static/js/actions/tests/DownloadActionManager.test.js | Improves dataset/capture download tests and DOMUtils mocking. |
| gateway/sds_gateway/static/js/actions/tests/DetailsActionManager.test.js | Adds dataset modal loading tests for owner and shared viewers. |
| gateway/sds_gateway/static/js/actions/PublishActionManager.js | Exposes PublishActionManager on window and via module.exports for Jest. |
| gateway/sds_gateway/static/js/actions/DetailsActionManager.js | Removes dataset details button flow; loads dataset details on modal show; awaits async file-tree rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lucaspar
approved these changes
Feb 16, 2026
05b4192 to
92630fd
Compare
lucaspar
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFDS-308
In this PR:
sanitize_path_rel_to_userwhich assumes path is owned by user)