ci(*): update helm-chart-smoketest.yml, add wasmtime-v1 coverage#605
Open
vdice wants to merge 2 commits intospinframework:mainfrom
Open
ci(*): update helm-chart-smoketest.yml, add wasmtime-v1 coverage#605vdice wants to merge 2 commits intospinframework:mainfrom
vdice wants to merge 2 commits intospinframework:mainfrom
Conversation
Signed-off-by: Vaughn Dice <vdice@akamai.com>
11 tasks
vdice
force-pushed
the
ci/update-smoketest-add-wasmtime-coverage
branch
from
09f7f14 to
b01c353
Compare
Signed-off-by: Vaughn Dice <vdice@akamai.com>
vdice
force-pushed
the
ci/update-smoketest-add-wasmtime-coverage
branch
from
b01c353 to
70ced6e
Compare
| run: | | ||
| timeout 60s bash -c 'until [[ "$(kubectl -n rcm get $(kubectl get pods -n rcm --no-headers -o name | grep install | head -n1) -o jsonpath="{.status.phase}" 2>/dev/null)" == "Succeeded" ]]; do sleep 2; done' | ||
| for shim_file in $(ls config/samples/sample_shim*); do | ||
| label="$(cat $shim_file | yq '.spec.nodeSelector' | tr -d '"' | tr -d '[:space:]' | sed s/:/=/g)" |
Contributor
There was a problem hiding this comment.
I realize this shell-based approach is probably nearing the limits of maintainability/readability.
I think script is fine but can we move these to a scripts/ directory and call the scripts instead of inlining here?
| kubectl label node --all $label | ||
|
|
||
| shim_name="$(cat $shim_file | yq '.metadata.name')" | ||
| # TODO: k3d can take a long round of failed install pods (exit code 6 when curling the artifact?) |
Contributor
There was a problem hiding this comment.
For K3d, SystemdCgroups: true should be removed (or set to false) in the sample shim. Can we add a conditional sed for that? More context: #393 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Notes:
Issue ticket number and link
Depends on #604 (Can rebase after that lands)
Closes #602