Skip to content

Implement retry logic on downloader#606

Open
Shunpoco wants to merge 5 commits intospinframework:mainfrom
Shunpoco:implement-downloader-retry
Open

Implement retry logic on downloader#606
Shunpoco wants to merge 5 commits intospinframework:mainfrom
Shunpoco:implement-downloader-retry

Conversation

@Shunpoco
Copy link
Contributor

@Shunpoco Shunpoco commented Feb 21, 2026

Describe your changes

A downloader needs a retry logic for curl, because sometimes network trouble happens.

This PR does:

  • Add a retry logic in the downloader shell script. The number of retry and sleep duration between iteration are configurable
  • Modify helm chart to add a ConfigMap for setting those variables on downloader container
  • Modify Reconciler code to add the ConfigMap if it is specified
  • Add a verification step for a ConfigMap from helm chart to actual installer pod

Issue ticket number and link

#591

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

Signed-off-by: Shunpoco <tkngsnsk313320@gmail.com>
Signed-off-by: Shunpoco <tkngsnsk313320@gmail.com>
Signed-off-by: Shunpoco <tkngsnsk313320@gmail.com>
Signed-off-by: Shunpoco <tkngsnsk313320@gmail.com>
@Shunpoco Shunpoco force-pushed the implement-downloader-retry branch from 6607064 to 0e6dca9 Compare February 21, 2026 10:47
Signed-off-by: Shunpoco <tkngsnsk313320@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant