feat: adjust pom struct #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Contributor
|
LGTM, GREATE! |
chickenlj
requested changes
Nov 24, 2025
|
|
||
| <description>AnalyticDB vector store implementation for Spring AI Alibaba</description> | ||
| <url>https://github.com/alibaba/spring-ai-alibaba</url> | ||
| <artifactId>spring-ai-alibaba-analyticdb-store</artifactId> |
Member
There was a problem hiding this comment.
I think change of artifactId from spring-ai-alibaba-starter-store-analyticdb to spring-ai-alibaba-analyticdb-store is unnecessary.
It brings only little benefit compared to the extra burdens for users who want to upgrade.
Member
Author
There was a problem hiding this comment.
yep, you are right.
There are two reasons for updating the artifact name:
- To align with Spring AI, the DashScope Vector Store has tightly coupled the specific implementation with the Starter, and I think they need to be separated. We can move the vector store to the spring-boot-starter directory, which should allow for a seamless migration without user perception;
- To standardize the directory structure, as the current project structure appears a bit chaotic.
For the first one, I think we can complete this before officially releasing version 1.1.0.0. This is a good opportunity to organize the directory structure. and i believe this is the final version of the directory structure. 🤔
It’s also acceptable to maintain the status quo, as this minimizes the migration cost for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AS TITLE