Skip to content

Fix: Add validation to prevent creating a pet with an empty name #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sagar-Sharma19-cmd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Add validation to prevent creating a pet with an empty name #2149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/org/springframework/samples/petclinic/owner/PetController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ public String initCreationForm(Owner owner, ModelMap model) {
@PostMapping("/pets/new")
public String processCreationForm(Owner owner, @Valid Pet pet, BindingResult result,
RedirectAttributes redirectAttributes) {
// Validate empty name
if (!StringUtils.hasText(pet.getName())) {
Copy link
Contributor

@andrzejsydor andrzejsydor Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why here, not in the Pet model?

result.rejectValue("name", "required", "Pet name must not be empty");
Copy link
Member

@dsyer dsyer Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like "required" already has a message associated with it, and it doesn't start with a capital letter - the third argument here is probably redundant?

return VIEWS_PETS_CREATE_OR_UPDATE_FORM;
}

if (StringUtils.hasText(pet.getName()) && pet.isNew() && owner.getPet(pet.getName(), true) != null)
result.rejectValue("name", "duplicate", "already exists");
Expand Down