Fix subnet_pool mapping in os_networks role

[bbezak]

Align subnet pool param with openstack.cloud module [1]

[1] https://github.com/openstack/ansible-collections-openstack/blob/1dc367b566611972604570c4d225f13b4f0ece57/plugins/modules/subnet.py#L131

[gemini-code-assist]

Summary of Changes

Hello @bbezak, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing consistency within the os_networks role by standardizing the parameter used for specifying subnet pools. The subnetpool parameter has been updated to subnet_pool to match the openstack.cloud module, improving overall API alignment and maintainability. The change includes provisions for backward compatibility, ensuring that existing configurations continue to operate without disruption while encouraging the adoption of the new parameter name. This update also signifies a minor version increment for the collection.

Highlights

• Parameter Renaming: The subnetpool parameter in the os_networks role has been renamed to subnet_pool to align with the openstack.cloud module's naming conventions.
• Backward Compatibility: Backward compatibility has been implemented, allowing the older subnetpool parameter to still function as a legacy alias for subnet_pool.
• Documentation Update: The README.md for the os_networks role has been updated to reflect the new subnet_pool parameter and document the legacy alias.
• Version Bump: The collection version in galaxy.yml has been updated from 0.8.1 to 0.9.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly aligns the os_networks role with the openstack.cloud.subnet module by renaming the subnetpool parameter to subnet_pool. Backward compatibility is maintained by treating the old parameter name as an alias, which is a good approach. The documentation in README.md and the collection version in galaxy.yml are also updated accordingly. The changes are well-implemented. I have one minor suggestion to improve the documentation clarity in the README file to make the deprecation of the old parameter more explicit.