Jd address scope subnet pool

[darmach]

Add two tasks creating address scopes and subnet pools.

[gemini-code-assist]

Summary of Changes

Hello @darmach, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the os_networks Ansible role by adding capabilities to provision and manage OpenStack Neutron address scopes and subnet pools. These additions streamline the automation of complex network configurations, allowing for more granular control over IP address allocation and network segmentation within an OpenStack environment.

Highlights

• OpenStack Address Scope Management: Introduced a new Ansible task to ensure OpenStack address scopes are properly registered and managed within Neutron, utilizing the openstack.cloud.address_scope module.
• OpenStack Subnet Pool Management: Added a new Ansible task to manage OpenStack subnet pools in Neutron, leveraging the openstack.cloud.subnet_pool module. This task also supports associating subnet pools with address scopes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for creating OpenStack address scopes and subnet pools by adding two new tasks to roles/os_networks/tasks/networks.yml. My review has identified a few issues with parameter handling in the new tasks. Specifically, a required parameter is treated as optional, an optional parameter is treated as required, and support for the project parameter is missing, which is inconsistent with the rest of the role. I've left specific comments with suggestions to fix these. More significantly, this pull request appears to be incomplete. It introduces new variables os_networks_address_scopes and os_networks_subnet_pools but does not define them in roles/os_networks/defaults/main.yml. This will cause the role to fail if they are not defined by the user. Additionally, the new functionality and variables are not documented in roles/os_networks/README.md, making it difficult for users to adopt these new features. Please consider adding the default variables and documentation to complete this change.