Skip to content

Show error if YouTube vertical dual stream fails. #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michelinewu wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −8
Open

Show error if YouTube vertical dual stream fails. #5664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions app/services/platforms/youtube.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,16 +550,24 @@ export class YoutubeService
}

if (this.streamingService.views.isDualOutputMode && ytSettings.display === 'both') {
// Prevent rate limit errors by delaying the dual stream setup by 1 second
await new Promise<void>(resolve => {
setTimeout(async () => {
await this.setupDualStream(goLiveSettings);
resolve();
}, 1000);
});
try {
// Prevent rate limit errors by delaying the dual stream setup by 1 second
await new Promise<void>(resolve => {
setTimeout(async () => {
await this.setupDualStream(goLiveSettings);
resolve();
}, 1000);
});
} catch (e: unknown) {
console.error('Error setting up YouTube dual stream', e);

// Catch error to prevent blocking the horizontal stream starting if there is an issue
// setting up the vertical stream
this.postError('Error setting up YouTube dual stream. Vertical stream not started.');
}
}

// Updating the thumbnail in the stream settings happends when creating the broadcast.
// Updating the thumbnail in the stream settings happens when creating the broadcast.
// This is because the user can still go live even if the thumbnail upload fails,
// and we want to avoid setting an invalid thumbnail in state.
if (ytSettings.thumbnail && ytSettings.thumbnail !== 'default') {
Expand Down
Loading