Skip to content

Fix resource leaks and unsafe shell commands in Python scripts #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shbhmexe wants to merge 2 commits into from
Closed

Fix resource leaks and unsafe shell commands in Python scripts #2722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb2b314
Fix resource leaks and unsafe subprocess usage in Python scripts
shbhmexe Feb 1, 2026
606462d
Refactor formatting and line handling in config.py
shbhmexe Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions SU2_PY/SU2/eval/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,9 +624,8 @@ def multipoint(config, state=None, step=1e-2):
dst = os.path.abspath(dst).rstrip("/") + "/" + "DIRECT"

# make unix link
string = "ln -s " + src + " " + dst
stringlist = string.split()
subprocess.Popen(stringlist)
if not os.path.exists(dst):
os.symlink(src, dst)

for i in range(len(weight_list) - 1):

Expand Down
10 changes: 4 additions & 6 deletions SU2_PY/SU2/eval/gradients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,9 +623,8 @@ def multipoint(func_name, config, state=None, step=1e-2):
dst = os.path.abspath(dst).rstrip("/") + "/"

# make unix link
string = "ln -s " + src + " " + dst
string_list = string.split()
subprocess.Popen(string_list)
if not os.path.exists(dst):
os.symlink(src, dst)

for i in range(len(weight_list) - 1):

Expand Down Expand Up @@ -736,9 +735,8 @@ def multipoint(func_name, config, state=None, step=1e-2):
src = os.path.abspath(src).rstrip("/") + "/" + ztate.FILES[ADJ_NAME]

# make unix link
string = "ln -s " + src + " " + dst
string_list = string.split()
subprocess.Popen(string_list)
if not os.path.exists(dst):
os.symlink(src, dst)

# Update MULTPOINT_ADJOINT files in state.FILES
state.FILES[MULTIPOINT_ADJ_NAME] = solution_adj_list
Expand Down
Loading
Loading