feat(core): expose metadata from YAML extension files#691
Open
benbellick wants to merge 2 commits intomainfrom
Open
feat(core): expose metadata from YAML extension files#691benbellick wants to merge 2 commits intomainfrom
benbellick wants to merge 2 commits intomainfrom
Conversation
Implements support for reading and exposing the optional metadata field from YAML extension files at runtime. This allows users to extend Substrait with custom metadata at three levels: - Extension-level: via ExtensionCollection.getExtensionMetadata(urn) - Type-level: via Type.metadata() - Function-level: via ScalarFunctionVariant/AggregateFunctionVariant/ WindowFunctionVariant.metadata() Also updates substrait submodule to v0.80.0 which includes the metadata schema support. Closes #690
benbellick
force-pushed
the
benbellick/expose-yaml-metadata
branch
from
a0b8dbc to
712b0ba
Compare
nielspardon
reviewed
Mar 3, 2026
|
|
||
| public abstract Map<String, Option> options(); | ||
|
|
||
| public abstract Optional<Map<String, Object>> metadata(); |
Member
There was a problem hiding this comment.
I'm wondering whether it would be useful to have an interface instead of Object for e.g. creating custom YAML deserializers / serializers and whether we should allow to add them to the ObjectMapper in SimpleExtension.load().
Otherwise I'm fine with the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #690