fix: properly deprecate Time(stamp) in favor of PrecisionTime(stamp)#720
Merged
andrew-coleman merged 1 commit intosubstrait-io:mainfrom Mar 3, 2026
Merged
Conversation
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
force-pushed
the
par-depr-time
branch
from
77872b0 to
0ed37bd
Compare
andrew-coleman
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timewas originally deprecated in Substrait via substrait-io/substrait#788 but was not marked properly as deprecated. Similarly the deprecation in substrait-java has not been implemented properly.There are multiple places where the new
PrecisionTimetype has not been introduced, the deprecatedTimetype not being marked as deprecated and places where the even further back deprecatedTimestamptypes were not marked as deprecated.