Skip to content

build: switch to substrait-antlr#153

Merged
vbarua merged 7 commits intomainfrom
vbarua/substrait-antlr-integration
Mar 4, 2026
Merged

build: switch to substrait-antlr#153
vbarua merged 7 commits intomainfrom
vbarua/substrait-antlr-integration

Conversation

@vbarua
Copy link
Member

@vbarua vbarua commented Feb 27, 2026

Generated ANTLR code can now be found in the substrait-antlr package

BREAKING CHANGE: module substrait.gen.antlr has been removed

@vbarua vbarua force-pushed the vbarua/substrait-antlr-integration branch from f6c7f5e to 7fc9c65 Compare February 27, 2026 01:55
@vbarua vbarua force-pushed the vbarua/substrait-antlr-integration branch 2 times, most recently from 884cd0d to 84800ba Compare March 3, 2026 00:50
@vbarua
Copy link
Member Author

vbarua commented Mar 3, 2026

TestPyPI is having issues. Instead of publishing substrait-antlr to TestPyPI, I published https://pypi.org/project/vbarua-substrait-antlr/0.79.0/ from my own branch in https://github.com/vbarua/substrait-packaging/tree/python/substrait-antlr/v0.79.0 so that we can see how this integrates.

If this looks reasonable, I can update substrait-packaging to publish substrait-antlr and then update this PR.

@vbarua vbarua marked this pull request as ready for review March 3, 2026 00:57
@vbarua vbarua requested review from nielspardon and tokoko March 3, 2026 00:57
Copy link
Member

@nielspardon nielspardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbarua
Copy link
Member Author

vbarua commented Mar 3, 2026

PR to release substrait-antlr to PyPI substrait-io/substrait-packaging#9

@vbarua vbarua force-pushed the vbarua/substrait-antlr-integration branch from 936b078 to 81b70a7 Compare March 3, 2026 16:00
@vbarua vbarua merged commit 8c80fe2 into main Mar 4, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants