Update CI and linter, fix issues #23
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,85 @@ | ||
| # See https://golangci-lint.run/docs/linters/configuration/ | ||
| version: "2" | ||
| run: | ||
| tests: true | ||
| linters: | ||
| default: all | ||
| disable: | ||
| - nilnil | ||
| - tparallel | ||
| - err113 | ||
|
Comment on lines
5
to
+10
There was a problem hiding this comment. P2 | Confidence: Medium The linter configuration switches from enabling specific linters to enabling all and then disabling many. This approach may catch more issues but could introduce noise from linters not suited to this codebase. The extensive disable list (28+ linters) suggests the 'enable all' approach might not be optimal for this project's coding style and could make the configuration harder to maintain. |
||
| - errorlint | ||
| - noinlineerr | ||
| - wsl_v5 | ||
| - funcorder | ||
| - copyloopvar | ||
| - depguard | ||
| - dupword | ||
| - errname | ||
| - exhaustruct | ||
| - forbidigo | ||
| - forcetypeassert | ||
| - gochecknoglobals | ||
| - intrange | ||
| - ireturn | ||
| - lll | ||
| - mnd | ||
| - nonamedreturns | ||
| - paralleltest | ||
| - recvcheck | ||
| - tagalign | ||
| - tagliatelle | ||
| - testableexamples | ||
| - testifylint | ||
| - varnamelen | ||
| - wrapcheck | ||
| settings: | ||
| dupl: | ||
| threshold: 100 | ||
| errcheck: | ||
| check-type-assertions: true | ||
| check-blank: true | ||
| gocyclo: | ||
| min-complexity: 20 | ||
| cyclop: | ||
| max-complexity: 15 | ||
| misspell: | ||
| locale: US | ||
| unparam: | ||
| check-exported: true | ||
| exclusions: | ||
| generated: lax | ||
| rules: | ||
| - linters: | ||
| - gosec | ||
| - dupl | ||
| - funlen | ||
| - goconst | ||
| - mnd | ||
| - noctx | ||
| - unparam | ||
| - unused | ||
| path: _test.go | ||
| - linters: | ||
| - errcheck | ||
| - gosec | ||
| path: example_ | ||
| - linters: | ||
| - revive | ||
| text: 'unused-parameter: parameter' | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
| formatters: | ||
| enable: | ||
| - gci | ||
| - gofmt | ||
| - gofumpt | ||
| - goimports | ||
| exclusions: | ||
| generated: lax | ||
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -198,7 +198,7 @@ func (c Comparer) filterExpected(expected []byte) ([]byte, error) { | |||||
| return nil, fmt.Errorf("failed to marshal var %s: %v", k, err) // Not wrapping to support go1.12. | ||||||
| } | ||||||
|
|
||||||
| expected = bytes.Replace(expected, []byte(`"`+k+`"`), j, -1) //nolint:gocritic,staticcheck // To support go1.11. | ||||||
|
There was a problem hiding this comment. P2 | Confidence: High The added staticcheck nolint directive suppresses a legitimate lint warning about using deprecated functionality (bytes.Replace with -1 count). Since the project now uses Go 1.17+ (per go.mod), this should be updated to use bytes.ReplaceAll() for better clarity and forward compatibility, as the current approach relies on deprecated behavior.
Suggested change
Evidence: method:bytes.Replace, search:gocritic,staticcheck |
||||||
| } | ||||||
| } | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ module github.com/swaggest/assertjson | |
| go 1.17 | ||
|
|
||
| require ( | ||
| github.com/bool64/dev v0.2.43 | ||
| github.com/bool64/shared v0.1.5 | ||
| github.com/iancoleman/orderedmap v0.3.0 | ||
| github.com/stretchr/testify v1.4.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| github.com/bool64/dev v0.2.17/go.mod h1:iJbh1y/HkunEPhgebWRNcs8wfGq7sjvJ6W5iabL8ACg= | ||
| github.com/bool64/dev v0.2.43 h1:yQ7qiZVef6WtCl2vDYU0Y+qSq+0aBrQzY8KXkklk9cQ= | ||
| github.com/bool64/dev v0.2.43/go.mod h1:iJbh1y/HkunEPhgebWRNcs8wfGq7sjvJ6W5iabL8ACg= | ||
| github.com/bool64/shared v0.1.5 h1:fp3eUhBsrSjNCQPcSdQqZxxh9bBwrYiZ+zOKFkM0/2E= | ||
| github.com/bool64/shared v0.1.5/go.mod h1:081yz68YC9jeFB3+Bbmno2RFWvGKv1lPKkMP6MHJlPs= | ||
| github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 | Confidence: High
The change replaces specific Go version pinning (1.20.x) with 'stable', which introduces non-deterministic build behavior. This could cause the gorelease tool to analyze the code against different Go versions over time, potentially leading to inconsistent API compatibility reports. For a release tooling workflow, deterministic behavior is critical to ensure consistent analysis results across different runs.
Evidence: constant:GO_VERSION, search:stable