Skip to content

chore: integrate latest ldk-node and bitkit-core #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ovitrif merged 13 commits into from
Jan 26, 2026
Merged

chore: integrate latest ldk-node and bitkit-core #718

ovitrif merged 13 commits into from
Jan 26, 2026
+108 −130

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 23, 2026 •
edited
Loading

Fixes: #723
Fixes: #667

Description

  1. Updates ldk-node and bitkit-core to latest versions

QA Notes

Use CI checks.

@claude

This comment has been minimized.

Sign in to view
@ovitrif ovitrif closed this Jan 23, 2026
@ovitrif ovitrif reopened this Jan 23, 2026
@ovitrif ovitrif changed the base branch from master to claude/issue-548-20260120-1551 January 23, 2026 03:27
@ovitrif ovitrif changed the title feat: optimize ldk-node usage and remove external fee screen chore: use latest ldk-node and bitkit-core Jan 23, 2026
@ovitrif ovitrif changed the title chore: use latest ldk-node and bitkit-core chore: integrate latest ldk-node and bitkit-core Jan 23, 2026
@jvsena42

This comment was marked as resolved.

Sign in to view
jvsena42

This comment was marked as outdated.

Sign in to view

Base automatically changed from claude/issue-548-20260120-1551 to master January 23, 2026 11:08
@ovitrif ovitrif dismissed jvsena42’s stale review January 23, 2026 11:08

The base branch was changed.

@jvsena42 jvsena42 enabled auto-merge January 23, 2026 11:13
@jvsena42

This comment was marked as resolved.

Sign in to view
jvsena42

This comment was marked as resolved.

Sign in to view

@piotr-iohk

This comment was marked as resolved.

Sign in to view
@ovitrif

This comment was marked as resolved.

Sign in to view
@piotr-iohk

This comment was marked as resolved.

Sign in to view
@ovitrif

This comment was marked as resolved.

Sign in to view
piotr-iohk
piotr-iohk reviewed Jan 23, 2026
View reviewed changes
@claude

This comment has been minimized.

Sign in to view
@ovitrif ovitrif force-pushed the feat/optimise-ldk-node-use branch 2 times, most recently from 50b5703 to dded9a5 Compare January 25, 2026 22:33
@ovitrif ovitrif marked this pull request as draft January 26, 2026 12:10
auto-merge was automatically disabled January 26, 2026 12:10

Pull request was converted to draft

@ovitrif

This comment was marked as resolved.

Sign in to view
@jvsena42 jvsena42 mentioned this pull request Jan 26, 2026
Closed
@ovitrif ovitrif force-pushed the feat/optimise-ldk-node-use branch from dded9a5 to 1d9bbe6 Compare January 26, 2026 12:48
@ovitrif ovitrif marked this pull request as ready for review January 26, 2026 14:08
@ovitrif ovitrif marked this pull request as draft January 26, 2026 14:15
@ovitrif ovitrif force-pushed the feat/optimise-ldk-node-use branch from 76beac4 to aeadbe9 Compare January 26, 2026 14:25
@claude

This comment has been minimized.

Sign in to view
ben-kaufman
ben-kaufman reviewed Jan 26, 2026
View reviewed changes
@jvsena42
Copy link
Member

jvsena42 commented Jan 26, 2026

LGTM, doing sanity tests...

claude[bot]
claude bot reviewed Jan 26, 2026
View reviewed changes
@ovitrif ovitrif marked this pull request as draft January 26, 2026 14:37
@ovitrif
Copy link
Collaborator Author

ovitrif commented Jan 26, 2026 •
edited
Loading

still need to fix LNURL-channel after bitkit-core changes.

see: plan

@jvsena42
Copy link
Member

jvsena42 commented Jan 26, 2026

probably fixes
#667

@ovitrif ovitrif marked this pull request as ready for review January 26, 2026 14:47
@ovitrif
Copy link
Collaborator Author

ovitrif commented Jan 26, 2026 •
edited
Loading

@piotr-iohk the LNURL-channel e2e failures were due to changes in a recent bitkit-core version and misalignment on the android side, which should now be fixed in commit:
dee14a9

Let's see if the e2e succeed 🤞🏻

@ovitrif ovitrif enabled auto-merge January 26, 2026 14:56
@jvsena42
Copy link
Member

jvsena42 commented Jan 26, 2026

Screen_recording_20260126_121653.webm

The app status screen show an Electrum error connection but the detail screen show success. I'll check if also happens on master

@ovitrif
Copy link
Collaborator Author

ovitrif commented Jan 26, 2026

Screen_recording_20260126_121653.webm
The app status screen show an Electrum error connection but the detail screen show success. I'll check if also happens on master

It's a known issue, I don't think you'll be able to repro it that easily.
It's not deterministic to my knowledge, aka. intermittent.

@ben-kaufman
Copy link
Contributor

ben-kaufman commented Jan 26, 2026

@jvsena42 do you have the logs from this?

@jvsena42
Copy link
Member

jvsena42 commented Jan 26, 2026 •
edited
Loading

@jvsena42 do you have the logs from this?

bitkit_2026-01-26_15-16-16.log
bitkit_2026-01-26_15-13-36.log

It is intermittent and didn't find a relation with this branch

jvsena42
jvsena42 previously approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Migration
  • Performed Lightning operations

@ovitrif
Copy link
Collaborator Author

ovitrif commented Jan 26, 2026 •
edited
Loading

@jvsena42 do you have the logs from this?

bitkit_2026-01-26_15-16-16.log bitkit_2026-01-26_15-13-36.log

It is intermittent and didn't find a relation with this branch

Can't repro it on this branch but I saw it quite often (last week-ish). Especially when clicking the wake2 notification

claude[bot]

This comment was marked as resolved.

Sign in to view

@ben-kaufman ben-kaufman mentioned this pull request Jan 26, 2026
Merged
@ovitrif ovitrif merged commit f2fe18e into master Jan 26, 2026
16 checks passed
@ovitrif ovitrif deleted the feat/optimise-ldk-node-use branch January 26, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@ben-kaufman ben-kaufman ben-kaufman approved these changes

@jvsena42 jvsena42 jvsena42 left review comments

@piotr-iohk piotr-iohk Awaiting requested review from piotr-iohk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Impossible to complete Lightning payments to Phoenix and Homegate (Franky) Bitkit to phoenx error paying bolt11

5 participants

@ovitrif @jvsena42 @piotr-iohk @ben-kaufman