fix: graceful null handling and idempotent stop #726
+49
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LightningService.stop()idempotent (succeed if node is already null instead of throwing)listenForEventsto use a stable reference throughout the event loopgetBalancesAsync/getChannelsAsyncLightningNodeService.onDestroy()since stop is now idempotentContext
This addresses pre-existing issues exposed by the crash logs shared in PR #717:
getBalancesAsynccrash:checkNotNull(lightningService.balances)threwIllegalStateException='Required value was null.'becausenode?.listBalances()returned null when the underlying LDK node was stoppedLightningService.stop()threwNodeNotStartedwhennodewas already nulllistenForEventsaccessedthis.nodeon each loop iteration, which could return null mid-loop when stop was called concurrentlyNote: The
nodeproperty is already@Volatilewhich provides sufficient thread-safety for the reference itself. These are not thread-safety issues with the reference - they're about handling the case when the LDK node object is stopped and its methods return null.Test plan
./gradlew compileDevDebugKotlin./gradlew testDevDebugUnitTest./gradlew detekt