fix: avoid showing sync failed immediately when app comes to foreground#359
Merged
fix: avoid showing sync failed immediately when app comes to foreground#359
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ovitrif
previously approved these changes
Jan 16, 2026
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
utAck
maybe 1 little nit:
could use init instead of initialize/ initialization in fn names 🙏🏻
This comment has been minimized.
This comment has been minimized.
ovitrif
previously approved these changes
Jan 16, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…m/synonymdev/bitkit-ios into fix/sync-failed-coming-foreground
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pwltr
requested changes
Jan 16, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jvsena42
reviewed
Jan 22, 2026
pwltr
reviewed
Jan 22, 2026
pwltr
reviewed
Jan 22, 2026
Member
|
Testing... |
pwltr
approved these changes
Jan 22, 2026
jvsena42
approved these changes
Jan 22, 2026
Member
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
Tested:
- Switch the app multiple times
- Close, remove from recents and open again
BitcoinErrorLog
pushed a commit
to BitcoinErrorLog/bitkit-ios
that referenced
this pull request
Feb 7, 2026
…ing-foreground fix: avoid showing sync failed immediately when app comes to foreground
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent node from stopping immediately when going to background and fix app getting stuck on app status
Fix #348