fix: use baseUrl for discord oauth redirect to support local development #1478
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcigdemoglu is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
How can I get a review on this PR @carloschida @t3dotgg ? |
| clientId: options.discordClientId, | ||
| clientSecret: options.discordClientSecret, | ||
| redirectURI: `${options.productionUrl}/api/auth/callback/discord`, | ||
| redirectURI: `${options.baseUrl}/api/auth/callback/discord`, |
Member
There was a problem hiding this comment.
hmm wont this break oauth proxy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Discord OAuth redirectURI from
options.productionUrltooptions.baseUrlto enable proper redirect handling in local development environments.Problem:
productionUrlwhich prevented local development testingSolution:
baseUrlinstead which correctly adapts to the current environment (local or production)baseURLconfigurationChanges:
packages/auth/src/index.tsline 37