-
Notifications
You must be signed in to change notification settings - Fork 113
Editorial: Make "structurally valid language tag" an auto-linked term #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Editorial: Make "structurally valid language tag" an auto-linked term #1008
Conversation
…nical" to "structurally valid" Canonicalization is already performed by MakeLocaleRecord, and not needed before it.
| 1. Let _tag_ be ? ToString(_tag_). | ||
| 1. Set _options_ to ? CoerceOptionsToObject(_options_). | ||
| 1. If IsStructurallyValidLanguageTag(_tag_) is *false*, throw a *RangeError* exception. | ||
| 1. Set _tag_ to CanonicalizeUnicodeLocaleId(_tag_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing canonicalisation is still a normative change: #804 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, that's twice now... this is clearly too subtle, so I've added an explanatory note.
…m "canonical" to "structurally valid"
…nicalization The relevant algorithms are buried rather deep in that section.
|
@anba could you take a quick look again? Thanks! |
aphillips
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. There are many places where we've managed the language tag validation jargon into "well-formed" vs. "valid". I know there is additional complexity in the locale identifier space, but we should be cautious not to make understanding more difficult.
| <h1> | ||
| UpdateLanguageId ( | ||
| _tag_: a Unicode canonicalized locale identifier, | ||
| _tag_: a structurally valid language tag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"structurally valid language tag" already has the name "well-formed" in BCP47 (and elsewhere). The term "valid" also has a meaning in that space: it means that the subtags have been validated. Inventing a term here that uses the word "valid" but which means apparently "well-formed" would be bad news. I would strongly urge using "structurally well-formed language tag" if not just "well-formed language tag".
No description provided.