Bring polyfill in line with Intl Era Monthcode and update test262 commit #3199
+34
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion In the iterative guessing process of converting a calendar date to an ISO date, we can run afoul of the supported range when either of two things happen: - A calendar helper's estimateISODate() returns an estimate of 01-01 of whatever year, which may be -271821 - diffTotalDaysEstimate is positive and takes us past the end of the range In the places where either of these two things happen, clamp the ISO date to the supported range. It's possible there are other places that could error, but I haven't been able to find cases that would make them do so.
This was based on erroneous data in CLDR. See https://unicode-org.atlassian.net/browse/CLDR-11375
See the change in #3175 for details. `era` should not be added to the default options for PlainMonthDay, because [[era]] isn't copied in step 12.b of GetDateTimeFormat when defaults is MONTH-DAY. The spec is correct here, this brings the reference code into alignment with it.
ptomato
force-pushed
the
more-polyfill-fixes
branch
from
11ddb9d to
e0c68e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3199 +/- ##
==========================================
+ Coverage 96.74% 96.75% +0.01%
==========================================
Files 22 22
Lines 10348 10359 +11
Branches 1859 1863 +4
==========================================
+ Hits 10011 10023 +12
+ Misses 287 285 -2
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the pinned test262 commit and makes the necessary fixes in the reference polyfill for the tests to pass. (Also fixes a straggler from #3175.)