feat: space layout #2236
Merged
feat: space layout #2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 20135492339Details
💛 - Coveralls |
younocode
force-pushed
the
feat/space-layout
branch
3 times, most recently
from
bc4359b to
36ec2c7
Compare
|
Deployment Status: ❌ Failed |
younocode
force-pushed
the
feat/space-layout
branch
from
36ec2c7 to
4b4ba7b
Compare
|
Deployment Status: ✅ Success |
2 similar comments
|
Deployment Status: ✅ Success |
|
Deployment Status: ✅ Success |
younocode
force-pushed
the
feat/space-layout
branch
from
5194e85 to
adeedc7
Compare
|
Deployment Status: ❌ Failed |
|
Deployment Status: ✅ Success |
younocode
force-pushed
the
feat/space-layout
branch
from
adeedc7 to
5197761
Compare
|
Deployment Status: ✅ Success |
4 similar comments
|
Deployment Status: ✅ Success |
|
Deployment Status: ✅ Success |
|
Deployment Status: ✅ Success |
|
Deployment Status: ✅ Success |
younocode
force-pushed
the
feat/space-layout
branch
from
4051638 to
4b37a34
Compare
|
Deployment Status: ✅ Success |
1 similar comment
|
Deployment Status: ✅ Success |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a comprehensive space layout redesign, introducing a new hierarchical navigation structure with dedicated layouts for spaces, shared bases, and trash management. The changes include significant UI refactoring, new data model fields for tracking base creators, and enhanced navigation between spaces and bases.
Key Changes:
- Introduces dedicated layout components (SpaceInnerLayout, SpaceTrashLayout, SharedBaseLayout) for different space-related views
- Adds creator information tracking (
createdBy,createdUser,createdTime,lastModifiedTime) to base entities - Refactors base and space list rendering from grid cards to a table-like list view with expandable/collapsible sections
- Updates trash management to support space-specific filtering
- Enhances last visit tracking to support space-level navigation
Reviewed changes
Copilot reviewed 69 out of 69 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-lib/src/shadcn/ui/tree.tsx | Removed z-index and background classes from tree components for new isolation context |
| packages/ui-lib/src/shadcn/ui/accordion.tsx | Added innerClassName prop for more granular styling control |
| packages/sdk/src/model/base.ts | Added createdBy field to Base model |
| packages/sdk/src/config/react-query-keys.ts | Extended getSpaceTrash to support optional spaceId filtering |
| packages/openapi/src/user/last-visit/get.ts | Added Space to LastVisitResourceType enum |
| packages/openapi/src/trash/get.ts | Added optional spaceId parameter to trash schema |
| packages/openapi/src/base/get.ts | Extended base schema with creator and timestamp fields |
| packages/common-i18n/src/locales/*/space.json | Added translations for new base list UI and trash descriptions |
| packages/common-i18n/src/locales/*/common.json | Added "select" and "spaceTrash" translations |
| apps/nextjs-app/src/pages/space/trash.tsx | Updated to use SpaceTrashLayout |
| apps/nextjs-app/src/pages/space/shared-base.tsx | Updated to use SharedBaseLayout |
| apps/nextjs-app/src/pages/space/index.tsx | Added auto-redirect logic to last visited space |
| apps/nextjs-app/src/pages/space/[spaceId]/trash.tsx | New page for space-specific trash view |
| apps/nextjs-app/src/pages/space/[spaceId].tsx | Updated to use SpaceInnerLayout |
| apps/nextjs-app/src/features/app/layouts/SpaceTrashLayout.tsx | New layout for global space trash view |
| apps/nextjs-app/src/features/app/layouts/SpaceInnerLayout.tsx | New layout for individual space pages with sidebar |
| apps/nextjs-app/src/features/app/layouts/SharedBaseLayout.tsx | New layout for shared bases page |
| apps/nextjs-app/src/features/app/components/user/UserNav.tsx | Added truncation with title tooltips for long names/emails |
| apps/nextjs-app/src/features/app/components/space/SpaceRenaming.tsx | Added className prop for flexible styling |
| apps/nextjs-app/src/features/app/components/space/SpaceAvatar.tsx | New component for space avatars with color generation |
| apps/nextjs-app/src/features/app/components/space/SpaceActionBar.tsx | Adjusted button sizing and icon styling |
| apps/nextjs-app/src/features/app/components/sidebar/SidebarHeader.tsx | Updated padding and spacing |
| apps/nextjs-app/src/features/app/components/sidebar/Sidebar.tsx | Added responsive sidebar visibility based on screen size |
| apps/nextjs-app/src/features/app/components/collaborator-manage/space-inner/Collaborators.tsx | Added title tooltip for truncated collaborator names |
| apps/nextjs-app/src/features/app/components/SideBarFooter.tsx | Added truncation with tooltip for user name |
| apps/nextjs-app/src/features/app/blocks/trash/SpaceTrashPage.tsx | Refactored to show only space trash with simplified UI |
| apps/nextjs-app/src/features/app/blocks/trash/SpaceInnerTrashPage.tsx | New component for space-specific base trash |
| apps/nextjs-app/src/features/app/blocks/space/space-side-bar/StarButton.tsx | Increased icon size and adjusted styling |
| apps/nextjs-app/src/features/app/blocks/space/space-side-bar/SpaceSwitcher.tsx | New comprehensive space switcher with search and management |
| apps/nextjs-app/src/features/app/blocks/space/space-side-bar/SpaceSideBar.tsx | Updated layout with flexible pin list sizing |
| apps/nextjs-app/src/features/app/blocks/space/space-side-bar/SpaceList.tsx | Updated layout and improved select placeholder text |
| apps/nextjs-app/src/features/app/blocks/space/space-side-bar/SpaceInnerSideBar.tsx | New sidebar for space-specific navigation |
| apps/nextjs-app/src/features/app/blocks/space/space-side-bar/PinList.tsx | Enhanced with scrollable container and flexible sizing |
| apps/nextjs-app/src/features/app/blocks/space/hooks/useSpaceList.ts | New hook for space list data fetching |
| apps/nextjs-app/src/features/app/blocks/space/SpaceInnerPage.tsx | Refactored with new table-based base list layout |
| apps/nextjs-app/src/features/app/blocks/space/SpaceCard.tsx | Updated to use new BaseList component |
| apps/nextjs-app/src/features/app/blocks/space/SharedBasePage.tsx | Simplified to use BaseList component |
| apps/nextjs-app/src/features/app/blocks/space/RecentlyBase.tsx | Updated to use BaseList component |
| apps/nextjs-app/src/features/app/blocks/space/BaseList.tsx | New table-style base list with sorting and expand/collapse |
| apps/nextjs-app/src/features/app/blocks/space/BaseItem.tsx | New component for base row with inline editing and actions |
| apps/nextjs-app/src/features/app/blocks/base/hooks/useLastVisitBase.ts | New hook for last visit base data |
| apps/nextjs-app/src/features/app/blocks/base/base-side-bar/BaseNodeTree.tsx | Enhanced with empty state and skeleton support |
| apps/nextjs-app/src/features/app/blocks/base/base-side-bar/BaseNodeMore.tsx | Added open/setOpen props for dropdown control |
| apps/nestjs-backend/src/types/i18n.generated.ts | Updated with new translation types |
| apps/nestjs-backend/src/features/user/last-visit/last-visit.service.ts | Added space visit tracking and updated base list with createdBy |
| apps/nestjs-backend/src/features/trash/trash.service.ts | Enhanced to support space-specific trash filtering |
| apps/nestjs-backend/src/features/space/space.service.ts | Added creator user information fetching for bases |
| apps/nestjs-backend/src/features/collaborator/collaborator.service.ts | Added creator fields to shared base response |
| apps/nestjs-backend/src/features/base/base.service.ts | Added creator user information to base list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/nextjs-app/src/features/app/blocks/space/space-side-bar/PinList.tsx
Outdated
Show resolved
Hide resolved
apps/nextjs-app/src/features/app/blocks/trash/SpaceInnerTrashPage.tsx
Outdated
Show resolved
Hide resolved
boris-w
approved these changes
Dec 11, 2025
…t and descriptions
…ogic in BaseList component
…s for cleaner code
younocode
force-pushed
the
feat/space-layout
branch
from
3fb5cdc to
4652ba8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 70 out of 70 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/nextjs-app/src/features/app/blocks/space/space-side-bar/SpaceList.tsx
Show resolved
Hide resolved
apps/nextjs-app/src/features/app/blocks/base/base-node/hooks/useBaseNode.ts
Show resolved
Hide resolved
|
Deployment Status: ✅ Success |
younocode
force-pushed
the
feat/space-layout
branch
from
a50e1fc to
085ca6f
Compare
younocode
force-pushed
the
feat/space-layout
branch
from
c68a1ae to
085ca6f
Compare
…mprove readability
🧹 Preview Environment Cleanup
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.