fix: add lightbox otherProps

[dududuna]

Summary by CodeRabbit

• New Features
  • Lightbox component now supports passing additional custom properties to the underlying image rendering for enhanced per-image customization capabilities.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce an optional otherProps property to the ReactImageLightbox component's interface and implementation. This property allows consumers to pass arbitrary attributes to the underlying image renderer without modifying component logic.

Changes

Cohort / File(s)	Summary
Prop forwarding interface packages/components/src/lightbox/interface.ts	Added optional otherProps?: any property to IReactImageLightboxProps interface
Prop forwarding implementation packages/components/src/lightbox/react-image-lightbox.tsx	Destructures otherProps from component props and spreads it into the image renderer via {...otherProps} in the checkedComponent call

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Straightforward prop forwarding pattern with no complex logic
• Minimal surface area affecting only interface definition and a single spread operation
• Standard pass-through mechanism with no error handling or side effects to verify

Poem

🐰 A prop passes through with a whispered spread,
Props to the renderer, no complexity to dread,
Flexibility blooms in the lightbox's care,
More customization floats through the air! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding an otherProps property to enable prop forwarding in the lightbox component.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/components/src/lightbox/interface.ts (1)

39-39: Consider a more specific type for better type safety.

Using any bypasses TypeScript's type checking. Consider using a more specific type like Record<string, unknown> or defining an interface for the expected shape of otherProps.

Apply this diff for improved type safety:

-  otherProps?: any;
+  otherProps?: Record<string, unknown>;

packages/components/src/lightbox/react-image-lightbox.tsx (1)

1538-1683: Consider adding PropTypes definition for consistency.

The otherProps prop is not included in the PropTypes definition. While PropTypes are optional and this doesn't affect functionality, adding it would maintain consistency with the rest of the component's prop documentation.

Add this entry to the PropTypes definition:

  // custom loader
  loader: PropTypes.node,
+
+  // Additional props to pass to the image renderer component
+  otherProps: PropTypes.object,
};

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 15bf51b and b1e614e.

📒 Files selected for processing (2)

• packages/components/src/lightbox/interface.ts (1 hunks)
• packages/components/src/lightbox/react-image-lightbox.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: test-coverage
• GitHub Check: tests

🔇 Additional comments (2)

packages/components/src/lightbox/react-image-lightbox.tsx (2)

1273-1273: LGTM!

The destructuring of otherProps from props is clean and follows the established pattern in this component.

---

1330-1341: Excellent prop spreading pattern.

The implementation correctly spreads otherProps first, then applies explicit props. This ensures that internal component props (like onDoubleClick, onWheel) take precedence over any conflicting props in otherProps, maintaining component integrity while allowing flexibility.

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	24.43%	26689 / 109245
🔵	Statements	24.43%	26689 / 109245
🔵	Functions	62.99%	2092 / 3321
🔵	Branches	84.48%	6957 / 8235

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/components/src/lightbox/interface.ts	100%	100%	100%	100%
packages/components/src/lightbox/react-image-lightbox.tsx	0%	0%	0%	0%	1-1722

Generated in workflow #215 for commit a42e5b0 by the Vitest Coverage Report Action