fix(auth): support running migrations for the first time during auth installation#1823
fix(auth): support running migrations for the first time during auth installation#1823MohammadAlhallaq wants to merge 6 commits intotempestphp:3.xfrom
Conversation
|
Hey, thanks! I don't think hardcoding the migration here is the right approach. I'd probably look into fixing the migration command inside the auth installer instead. |
yup, I agree, will be done 👍🏻 |
@innocenzi Hey, maybe a combination of checking in the manager and taking action in the installer, keeping the manager as our source of truth for whether the migrations table exists |
|
@brendt @innocenzi what do you guys think about this one ? |
|
Makes me wonder: why don't we just run |
just updated it, maybe something like this ? |
|
No I don't think this is the right approach because migrate:up will run all migrations, and you shouldn't have to manually run another after that. I'll take a look at this myself |
fixes #1684