Skip to content

Conversation

@mjameswh
Copy link
Contributor

@mjameswh mjameswh commented Nov 27, 2025

What changed

  • Convert all internal scripts to TypeScript (instead of pure JS).
  • Use tsx to run TS scripts.
  • Removed a few scripts and doc files that are no longer pertinent.
  • Do not build native code in Core Bridge on NPM's install. install can't be relied on, as it is disabled by some package managers due to security risks for users.

@mjameswh mjameswh marked this pull request as ready for review December 4, 2025 18:40
@mjameswh mjameswh requested a review from a team as a code owner December 4, 2025 18:40
@mjameswh
Copy link
Contributor Author

Need to replace the use of npm's --ignore argument in new pnpm commands. It is unknown and ignored by pnpm, causing Core to be rebuilt in CI during "Run integration tests" jobs; it shouldn't.

https://github.com/temporalio/sdk-typescript/actions/runs/20283391495/job/58251126305?pr=1842#step:7:1

@chris-olszewski
Copy link
Member

Need to replace the use of npm's --ignore argument in new pnpm commands. It is unknown and ignored by pnpm, causing Core to be rebuilt in CI during "Run integration tests" jobs; it shouldn't.

https://github.com/temporalio/sdk-typescript/actions/runs/20283391495/job/58251126305?pr=1842#step:7:1

--ignore is a lerna thing, moving scripts to a package so we can leverage keep the commands as is. I do have a branch locally that replaces most of our lerna usage with just straight pnpm, hoping to polish it during break.

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a few minor fixups, but otherwise LGTM.

Biggest change I did was moving the scripts to their own package so we could keep the top level build script in a way where we could pass args down to lerna without issue.

"version": "0.0.1",
"description": "Internal scripts for TS SDK repository",
"scripts": {
"build": "tsc --noEmit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really "building", but we need a new script to type check the scripts. For other packages we rely on test pulling them in for typechecking, but it doesn't make sense for scripts.

Decided to make a new scripts private package so we can keep our existing lerna based build strategy. No dependencies as these scripts's dependencies are hoisted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants