-
Notifications
You must be signed in to change notification settings - Fork 146
chore: Convert all scripts to TypeScript #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Need to replace the use of npm's |
|
chris-olszewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a few minor fixups, but otherwise LGTM.
Biggest change I did was moving the scripts to their own package so we could keep the top level build script in a way where we could pass args down to lerna without issue.
| "version": "0.0.1", | ||
| "description": "Internal scripts for TS SDK repository", | ||
| "scripts": { | ||
| "build": "tsc --noEmit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really "building", but we need a new script to type check the scripts. For other packages we rely on test pulling them in for typechecking, but it doesn't make sense for scripts.
Decided to make a new scripts private package so we can keep our existing lerna based build strategy. No dependencies as these scripts's dependencies are hoisted.
What changed
tsxto run TS scripts.install.installcan't be relied on, as it is disabled by some package managers due to security risks for users.