Add lastModified attribute to DSpaceObject#61
Merged
kshepherd merged 1 commit intothe-library-code:mainfrom Feb 27, 2026
Merged
Add lastModified attribute to DSpaceObject#61kshepherd merged 1 commit intothe-library-code:mainfrom
kshepherd merged 1 commit intothe-library-code:mainfrom
Conversation
* Add check for lastModified attribute in DSpaceObject.__init__ method to pass the attribute to child classes
Collaborator
|
Thanks @ehanson8 this looks perfect! I will look to release a new version soon so this change can be included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we incorporate
dspace-rest-pythoninto our DSpace submission workflows, I discovered that thelastModifiedattribute did not exist in theIteminstance after it was successfully created in DSpace. This was fixed by a simple addition to theDSpaceObjectclass.To confirm this change didn't create issues with
update_itemsincelastModifiedcan't be modified except by DSpace itself, I successfully calledupdate_itemwith a newly createdIteminstance where thelastModifiedattribute was set. This was possible becauseupdate_dso(which is called byupdate_item) removes the attribute with this block.Happy to do any further testing to confirm this doesn't break anything, thanks!