Skip to content

[Do not merge] dApp-friendly contract deployment #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
r-czajkowski wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[Do not merge] dApp-friendly contract deployment #118

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
beded5c
Fine-tuned unstake period
r-czajkowski Jul 28, 2022
a9a29a0
Add script that sets the min stake amount
r-czajkowski Jul 28, 2022
f9411c0
Add `CODEOWNERS` file
r-czajkowski Jul 28, 2022
c5bdf3d
Fix script
r-czajkowski Aug 11, 2022
9025679
Merge remote-tracking branch 'origin/main' into dapp-development
michalinacienciala Aug 18, 2022
18c679d
Change version's suffix to `-dapp-dev-goerli`
michalinacienciala Sep 1, 2022
eea1ea8
Merge branch 'main' into dapp-development
r-czajkowski Jan 4, 2023
65f6431
Merge remote-tracking branch 'origin/main' into dapp-development
michalinacienciala Nov 7, 2023
646a5c6
Switch to `dapp-dev-sepolia`
michalinacienciala Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.sol @pdyraga @nkuba @lukasz-zimnoch
Copy link
Member

@pdyraga pdyraga Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extract CODEOWNERS change to a separate PR and merge it to main.

The CODEOWNERS should cover all existing contracts from contracts/ directory

Let's add there all developers who worked on the Solidity code of the Threshold smart contracts: @vzotova @cygnusv @pdyraga

This will not only protect dApp-dev-only changes from being merged but will also protect from any accidental changes to an already audited code.

Copy link
Contributor Author

@r-czajkowski r-czajkowski Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#121

2 changes: 1 addition & 1 deletion contracts/staking/TokenStaking.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ contract TokenStaking is Initializable, IStaking, Checkpoints {
}

uint256 internal constant SLASHING_REWARD_PERCENT = 5;
uint256 internal constant MIN_STAKE_TIME = 24 hours;
uint256 internal constant MIN_STAKE_TIME = 120;
uint256 internal constant GAS_LIMIT_AUTHORIZATION_DECREASE = 250000;
uint256 internal constant CONVERSION_DIVISOR = 10**(18 - 3);

Expand Down
23 changes: 23 additions & 0 deletions deploy/09_set_minimum_stake.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { HardhatRuntimeEnvironment } from "hardhat/types"
import { DeployFunction } from "hardhat-deploy/types"

const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
const { getNamedAccounts, deployments } = hre
const { execute } = deployments
const { log } = deployments

const { deployer } = await getNamedAccounts()

const minStakeAmount = "39999999999999999999999"
Copy link
Member

@pdyraga pdyraga Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to set the minimum stake to 39999999999999999999999? With dApp team owning T token contract from dapp-development-goerli deployment, all devs should be able to mint any amount of T they want.

Copy link
Contributor Author

@r-czajkowski r-czajkowski Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

39999999999999999999999 is the current min stake on mainnet that's why I picked this number but we could change to any number. We want to set the min stake to test the min stake validation in T dapp.

await execute("TokenStaking", { from: deployer }, "setMinimumStakeAmount")

log(`Set minimum stake amount to ${minStakeAmount}`)
}

export default func

func.tags = ["setMinStakeAmount"]
func.dependencies = ["TokenStaking"]
func.skip = async function (hre: HardhatRuntimeEnvironment): Promise<boolean> {
return hre.network.name !== "goerli"
}