Feature insert precheck #49
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple of unit tests for wtfaremyinitials' attribute setter change. Also added another hook, insertPrecheck along with tests for same.
I have encountered two use cases that require the ability to skip insertion or to modify an element prior to insertion. This can be accomplished by overriding the insertPrecheck function and returning true to insert and false to not insert. If you don't override insertPrecheck, the default implementation in weld.js returns true (insert element). While this functionality could have been accomplished by overriding insert, I felt it less error prone to add another hook with a boolean return instead of having to override the insert function and duplicating the insert code.