Skip to content

Conversation

@kvz
Copy link
Member

@kvz kvz commented Oct 27, 2025

The Node SDK now has cli support for signing payloads, we can use it to compare our own signatures instead of handrolled Node.js code in this repo:

❯ npx transloadit --help
Usage:
  npx transloadit smart_sig    Read Smart CDN params JSON from stdin and output a signed URL.
  npx transloadit sig [--algorithm <name>]    Read params JSON from stdin and output signed payload JSON.

Required JSON fields:
  smart_sig: workspace, template, input
  sig: none (object is optional)
Optional JSON fields:
  smart_sig: expire_at_ms, url_params
  sig: auth.expires and any supported assembly params

As an aside, I added Docker so it's easier to test this SDK on machines that do not have the Ruby environment set up.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.00%. Comparing base (28060df) to head (dec4c92).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files           9        9           
  Lines         302      302           
  Branches       39       39           
=======================================
  Hits          299      299           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kvz kvz marked this pull request as ready for review October 28, 2025 18:51
@kvz kvz requested a review from rmehner October 28, 2025 19:17
@kvz
Copy link
Member Author

kvz commented Oct 28, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kvz kvz merged commit 76ace84 into main Oct 29, 2025
7 checks passed
@kvz kvz deleted the simple-parity branch October 29, 2025 12:14
@kvz
Copy link
Member Author

kvz commented Oct 29, 2025

I could see the asset blew the gem size up. Corrected:

image

@kvz
Copy link
Member Author

kvz commented Oct 29, 2025

Not sure what is idiomatic here. Should we remove this from the gem completely (but then you can't use it to fully test itself anymore?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants