Bugfixes for firstboot script issues#68
Open
JedMeister wants to merge 7 commits intoturnkeylinux:masterfrom
Open
Bugfixes for firstboot script issues#68JedMeister wants to merge 7 commits intoturnkeylinux:masterfrom
JedMeister wants to merge 7 commits intoturnkeylinux:masterfrom
Conversation
Member
Author
|
bump @OnGle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #66 & #67 - these PRs can be independently reviewed separately/first or just review everything in this PR if preferred - whatever works best for you.
Fixes:
firstboot.d/15regen-sslcertwas failing due tonginx.servicebeing listed by systemd but didn't actually existfirstboot.d/29tagidwas failing due to initfence html file not existing in /var/lib (due to package refactoring in Update turnkey init fence #66)/var/lib/inithooks/turnkey-init-fencedir does not exist, it is copied from/usr(where it was moved to in e77d288) before the changes are applied; rationale is that the files that are included with the package should be in/usr/lib(as per packaging change noted above) but files in/usr/libshould not be modified, instead the modified files should be in/var/lib- thus need to be copied across if they don't exist.Further testing is still required before we can consider this "done".
During preliminary testing it appears that the original changes in #67 (updated mechanism to launch inithooks/confconsole on tty1) still don't work quite as intended - at least not on the v19.0beta core I'm running live. I'm not sure why, but I manually started the new
inithooks.serviceand it hasn't rerun since then. It could be a race condition during boot perhaps? Or perhaps there is something that we haven't cleaned up properly/completely from the old way we used to do things?[update] Pushed new commit: 1d894b6. I'm not sure if that is the actual fix for the (ongoing) gett1 issue noted directly above, however it was clearly a bug.
Also I've noticed that my local trixie testing ISO build still has these files:
/etc/systemd/system/getty@tty1.service.d/10-getty-tkl-login.conf/etc/systemd/system/getty@tty1.service.d/override.conf/usr/lib/inithooks/bin/login_script.shBesides the fact that they shouldn't be there anymore at all (after #66 & #67) it's a bit weird that they ever existed together because both of the getty overrides do the same thing?! I.e. both override getty1 to start inithooks (prior bookworm functionality). Obviously I'm missing something but after checking the package contents (i.e. the code here) and common, I can't see where they are coming from?!