perf: metadata caching & hot path optimisations#2665
Open
matthew2564 wants to merge 6 commits intotypestack:developfrom
Open
perf: metadata caching & hot path optimisations#2665matthew2564 wants to merge 6 commits intotypestack:developfrom
matthew2564 wants to merge 6 commits intotypestack:developfrom
Conversation
Author
|
@braaar I've hopefully now fixed the issues detected in the pipeline (formatting & missing test cov) 👍 |
braaar
reviewed
Feb 25, 2026
Comment on lines
17
to
25
| for (const key in value ) { | ||
| if ((value ).hasOwnProperty(key)) { | ||
| const propertyValue = (value as any)[key]; | ||
| if (propertyValue !== null && propertyValue !== undefined) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| return false; |
Member
There was a problem hiding this comment.
Are you certain this is faster than the original, or did you make all the chances at once and then benchmark it all in bulk?
Author
There was a problem hiding this comment.
The for in approach is faster because it avoids allocating an intermediate array (like Object.values() does) and can short-circuit as soon as it finds a non-null/undefined value
Member
|
Could you fix the merge conflicts? |
…imisation # Conflicts: # src/validation/ValidationExecutor.ts
Member
|
Could you go over the tests to increase the coverage a bit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So the flow was:
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpasses