-
Notifications
You must be signed in to change notification settings - Fork 17
Add low aspect ratio demo case to the tracker #4020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tmargmin_cs -> tmargmin fvsbrnni -> f_c_plasma_non_inductive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4020 +/- ##
==========================================
- Coverage 45.89% 42.74% -3.16%
==========================================
Files 123 123
Lines 29064 32648 +3584
==========================================
+ Hits 13340 13954 +614
- Misses 15724 18694 +2970 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just need to check that @ajpearcey is happy with this file: |
ajpearcey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The burn time in this file drops from 2.11 hours to 1.4 hours. I will investigate why, I'm not comfortable adding this to the tracker until we understand this change.
👍. Is there a constraint we can use to get the burn time back up? Or is already a constraint that is being violated. |
Description
Closes #3554
Checklist
I confirm that I have completed the following checks: