Fix #10010: mv Cross-Device Symlink Fallback EEXIST #10069
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
please update the title of the PR |
|
GNU testsuite comparison: |
minimoog
changed the title
Author
|
I need to figure out how to test mv across device symlinks for WSL2, FreeBSD, OpenBSD and Android, since test is using /dev/shm as temp folder which works on Linux. |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mv uses symlink across filesystems instead relinking (returns EEXITS), now rename_symlink_fallback tries, atomically, to recreate the link if it's across devices.
Added test_mv_cross_device_symlink_overwrite() to test this scenario.