Skip to content

cp: Preserve mode for directories when copying by default. #9794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nikolalukovic wants to merge 7 commits into
base: main
Choose a base branch
from
Open

cp: Preserve mode for directories when copying by default. #9794

nikolalukovic wants to merge 7 commits into from
+159 −19

Conversation

@nikolalukovic
Copy link

@nikolalukovic nikolalukovic commented Dec 23, 2025

Attempts to fix: #7961

@nikolalukovic nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from e5a0699 to e96a0d6 Compare December 23, 2025 14:21
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

@nikolalukovic nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from aa40f09 to de4e3ec Compare December 23, 2025 16:19
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/existing-perm-dir. tests/cp/existing-perm-dir is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

@nikolalukovic nikolalukovic marked this pull request as draft December 23, 2025 20:41
sylvestre
sylvestre reviewed Dec 23, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?

@nikolalukovic nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from f782887 to 3eb23ee Compare January 4, 2026 14:27
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

GNU testsuite comparison:

GNU test failed: tests/cp/preserve-mode. tests/cp/preserve-mode is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!

@nikolalukovic nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from 7d33c02 to bd35186 Compare January 4, 2026 16:39
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

GNU testsuite comparison:

GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

@nikolalukovic
Copy link
Author

nikolalukovic commented Jan 4, 2026

This fix feels more like a human rights violation. I'll see how to streamline the checks that have to be done and do it in a more idiomatic Rust way.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!

@sylvestre
Copy link
Contributor

sylvestre commented Jan 4, 2026

the new "mut" aren't a good sign indeed ;)

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@nikolalukovic nikolalukovic marked this pull request as ready for review January 8, 2026 06:56
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@nikolalukovic nikolalukovic force-pushed the fix/7961 branch 2 times, most recently from caf8687 to 6aad24c Compare January 8, 2026 10:01
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@nikolalukovic nikolalukovic marked this pull request as draft January 8, 2026 14:35
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@nikolalukovic nikolalukovic marked this pull request as ready for review January 8, 2026 16:13
@nikolalukovic nikolalukovic force-pushed the fix/7961 branch 3 times, most recently from 9f17ad4 to 0be3ca6 Compare January 9, 2026 11:05
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@nikolalukovic
Copy link
Author

nikolalukovic commented Jan 9, 2026

@sylvestre ready for review

sylvestre
sylvestre reviewed Jan 9, 2026
View reviewed changes
src/uucore/src/lib/features/fs.rs
/// std::fs::create_dir("foo/."); fails in pure Rust
pub fn dir_strip_dot_for_creation(path: &Path) -> PathBuf {
let path_str = path.to_string_lossy();

Copy link
Contributor

@sylvestre sylvestre Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change

Copy link
Author

@nikolalukovic nikolalukovic Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Don't know how that got changed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cp behaves differently on read-only directories

2 participants

@nikolalukovic @sylvestre