Add support for `findmnt` by Harshit933 · Pull Request #210 · uutils/util-linux

Harshit933 · 2025-02-02T08:27:17Z

For now the output of findmnt is:

[harshit:~/dev/util-linux (findmnt|✔)] target/debug/util-linux findmnt
 target                                     source          fstype       options                                                                                               
 /                                          /dev/nvme0n1p7  ext4         rw,relatime                                                                                           
 /proc                                      proc            proc         rw,nosuid,nodev,noexec,relatime                                                                       
 /proc/sys/fs/binfmt_misc                   systemd-1       autofs       rw,relatime,fd=41,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=6207                         
 /proc/sys/fs/binfmt_misc                   binfmt_misc     binfmt_misc  rw,nosuid,nodev,noexec,relatime                                                                       
 /sys                                       sys             sysfs        rw,nosuid,nodev,noexec,relatime                                                                       
 /sys/firmware/efi/efivars                  efivarfs        efivarfs     rw,nosuid,nodev,noexec,relatime                                                                       
 /sys/kernel/security                       securityfs      securityfs   rw,nosuid,nodev,noexec,relatime                                                                       
 /sys/fs/cgroup                             cgroup2         cgroup2      rw,nosuid,nodev,noexec,relatime,nsdelegate,memory_recursiveprot                                       
 /sys/fs/pstore                             pstore          pstore       rw,nosuid,nodev,noexec,relatime                                                                       
 /sys/fs/bpf                                bpf             bpf          rw,nosuid,nodev,noexec,relatime,mode=700                                                              
 /sys/kernel/tracing                        tracefs         tracefs      rw,nosuid,nodev,noexec,relatime                                                                       
 /sys/kernel/debug                          debugfs         debugfs      rw,nosuid,nodev,noexec,relatime                                                                       
 /sys/fs/fuse/connections                   fusectl         fusectl      rw,nosuid,nodev,noexec,relatime                                                                       
 /sys/kernel/config                         configfs        configfs     rw,nosuid,nodev,noexec,relatime                                                                       
 /dev                                       dev             devtmpfs     rw,nosuid,relatime,size=8027368k,nr_inodes=2006842,mode=755,inode64                                   
 /dev/shm                                   tmpfs           tmpfs        rw,nosuid,nodev,inode64                                                                               
 /dev/pts                                   devpts          devpts       rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000                                                 
 /dev/hugepages                             hugetlbfs       hugetlbfs    rw,nosuid,nodev,relatime,pagesize=2M                                                                  
 /dev/mqueue                                mqueue          mqueue       rw,nosuid,nodev,noexec,relatime                                                                       
 /run                                       run             tmpfs        rw,nosuid,nodev,relatime,mode=755,inode64                                                             
 /run/credentials/systemd-journald.service  tmpfs           tmpfs        ro,nosuid,nodev,noexec,relatime,nosymfollow,size=1024k,nr_inodes=1024,mode=700,inode64,noswap         
 /run/user/1000                             tmpfs           tmpfs        rw,nosuid,nodev,relatime,size=1612004k,nr_inodes=403001,mode=700,uid=1000,gid=1000,inode64            
 /run/user/1000/doc                         portal          fuse.portal  rw,nosuid,nodev,relatime,user_id=1000,group_id=1000                                                   
 /tmp                                       tmpfs           tmpfs        rw,nosuid,nodev,nr_inodes=1048576,inode64                                                             
 /boot                                      /dev/nvme0n1p6  vfat         rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,utf8,errors=remount-ro

Potential fix #23

cakebaker · 2025-02-06T15:41:13Z

Can you please run cargo clippy? The CI shows some clippy errors. Plus the test fails on macOS because there's no /proc on macOS as far as I know.

Harshit933 · 2025-02-08T06:41:32Z

Plus the test fails on macOS because there's no /proc on macOS as far as I know.

Yup. I guess that is the case. I'll feature gate this on linux only

error: test failed, to rerun pass `--test tests`
run: /Users/runner/work/util-linux/util-linux/target/debug/util-linux findmnt
thread 'test_findmnt::test_findmnt' panicked at tests/by-util/test_findmnt.rs:5:17:
Command was expected to succeed. Exit code: 101.
stdout = 
 stderr = thread 'main' panicked at src/uu/findmnt/src/findmnt.rs:43:54:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

src/uu/findmnt/Cargo.toml

sylvestre · 2025-02-08T16:44:04Z

Yup. I guess that is the case. I'll feature gate this on linux only

there might be crate or equivalent for mac/unix. Maybe have a look before making this linux specific

Harshit933 · 2025-02-13T09:10:12Z

@sylvestre I see there are some alternatives present inside macOS like the mount and diskutil commands. But shouldn't they be implemented differently from the findmnt one? I am a bit confused here on what do I need to do further.

cakebaker · 2025-02-24T15:50:00Z

src/uu/findmnt/Cargo.toml

+path = "src/main.rs"
+
+[dependencies]
+tabled = { workspace = true }


We recently removed tabled and so this will no longer work. And as the output currently looks quite different from the output of the original findmnt, I think it is probably easier to do the output manually than trying to figure out how to do it with tabled.

@Harshit933 I had started working on a findmnt implementation as well before realizing you had this PR open, feel free to take the output code from here, that version doesn't use tabled.

Thanks for the pointer, I'll take a look.

Copilot

PR Overview

This PR adds support for the findmnt utility by introducing its own Rust package, command-line interface, and associated tests.

Added a new package (uu_findmnt) with implementation and CLI entry point.
Updated workspace configuration to include findmnt as a dependency.
Added tests and documentation for the new utility.

Reviewed Changes

File	Description
src/uu/findmnt/Cargo.toml	New package manifest for the findmnt utility
src/uu/findmnt/src/findmnt.rs	Core implementation including parsing and table formatting
src/uu/findmnt/src/main.rs	CLI entry point for findmnt
src/uu/findmnt/findmnt.md	Documentation for findmnt
tests/by-util/test_findmnt.rs	Test validating the findmnt output on Linux
Cargo.toml	Workspace dependencies updated to include findmnt
tests/tests.rs	Integration of findmnt tests into the overall test suite

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Copilot · 2025-03-08T12:43:38Z

src/uu/findmnt/src/findmnt.rs

+    pub fn form_nodes(&mut self) {
+        let res = fs::read_to_string(self.file_name).unwrap();


Using unwrap() here can lead to a panic if the mountinfo file cannot be read; consider handling the error gracefully with proper error messaging.

Suggested change

pub fn form_nodes(&mut self) {

let res = fs::read_to_string(self.file_name).unwrap();

pub fn form_nodes(&mut self) -> Result<(), Box<dyn std::error::Error>> {

let res = fs::read_to_string(self.file_name)?;

In some niche cases, /proc might not be mounted - I agree with Copilot here - but use UError instead.

Copilot · 2025-03-08T12:43:39Z

src/uu/findmnt/src/findmnt.rs

+        let (_, rest) = rest.trim().split_once("-").unwrap();
+        let (fstype, rest) = rest.trim().split_once(" ").unwrap();
+        let (source, rest) = rest.trim().split_once(" ").unwrap();
+        let options_added = if rest.split_once("rw").is_some() {


The current logic splitting on "rw" may be unreliable if the options string unexpectedly contains this substring; consider a more robust parsing strategy or document the assumptions clearly.

Copilot is correct here - I have a ro mounted partition and I'm unable to see it. This document specifies the exact format of the file.

xbjfk

Not a maintainer of uutils, so take this with a grain of salt, but will add my two cents.

xbjfk · 2025-04-20T10:38:10Z

src/uu/findmnt/src/findmnt.rs

+    pub fn form_nodes(&mut self) {
+        let res = fs::read_to_string(self.file_name).unwrap();


In some niche cases, /proc might not be mounted - I agree with Copilot here - but use UError instead.

xbjfk · 2025-04-20T11:07:03Z

src/uu/findmnt/src/findmnt.rs

+        let (_, rest) = rest.trim().split_once("-").unwrap();
+        let (fstype, rest) = rest.trim().split_once(" ").unwrap();
+        let (source, rest) = rest.trim().split_once(" ").unwrap();
+        let options_added = if rest.split_once("rw").is_some() {


Copilot is correct here - I have a ro mounted partition and I'm unable to see it. This document specifies the exact format of the file.

xbjfk · 2025-04-20T11:07:20Z

Cargo.toml

  "renice",
  "rev",
  "setsid",
+  "findmnt",


This should be in alphabetical order :)

Maybe the project should consider adding cargo sort to the CI.

xbjfk · 2025-04-20T11:07:33Z

Cargo.toml

 renice = { optional = true, version = "0.0.1", package = "uu_renice", path = "src/uu/renice" }
 rev = { optional = true, version = "0.0.1", package = "uu_rev", path = "src/uu/rev" }
 setsid = { optional = true, version = "0.0.1", package = "uu_setsid", path ="src/uu/setsid" }
+findmnt = { optional = true, version = "0.0.1", package = "uu_findmnt", path = "src/uu/findmnt" }


also should be alphabetical

xbjfk · 2025-04-20T11:13:08Z

there might be crate or equivalent for mac/unix. Maybe have a look before making this linux specific

On BSD, Mac OS and friends, there is getfsstat (man page) for this purpose. It's even easier as it is a real API and not a text file you need to parse :). It's available in the ubiquitous libc crate: getfsstat

You could theoretically write this for Windows too, but you would need to be a masochist :). You would need to consider not only drive letters, but also NTFS mount points and Network shares.

Harshit933 · 2025-04-30T14:12:59Z

Hey @xbjfk, thanks for the review. I will try to complete this PR at the end of this week. I am too much occupied with some work at the current moment.

First version of findmnt

7479731

sylvestre force-pushed the findmnt branch from d011cef to e1db6a8 Compare February 2, 2025 08:47

Harshit933 force-pushed the findmnt branch 2 times, most recently from 01071f2 to 2977baa Compare February 8, 2025 06:39

Harshit933 force-pushed the findmnt branch from 2977baa to 145fde7 Compare February 8, 2025 06:45

cakebaker reviewed Feb 8, 2025

View reviewed changes

src/uu/findmnt/Cargo.toml Outdated Show resolved Hide resolved

Add tests for findmnt

7bd0166

Harshit933 force-pushed the findmnt branch from 145fde7 to 7bd0166 Compare February 11, 2025 16:13

cakebaker mentioned this pull request Feb 16, 2025

Implement findmnt #222

Closed

cakebaker reviewed Feb 24, 2025

View reviewed changes

sylvestre requested a review from Copilot March 8, 2025 12:42

Copilot AI reviewed Mar 8, 2025

View reviewed changes

Merge branch 'main' into findmnt

221ed80

xbjfk suggested changes Apr 20, 2025

View reviewed changes

		pub fn form_nodes(&mut self) {
		let res = fs::read_to_string(self.file_name).unwrap();

Conversation

Harshit933 commented Feb 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cakebaker commented Feb 6, 2025

Uh oh!

Harshit933 commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sylvestre commented Feb 8, 2025

Uh oh!

Harshit933 commented Feb 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

PR Overview

Reviewed Changes

Uh oh!

Copilot AI Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

xbjfk Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xbjfk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xbjfk Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xbjfk commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Harshit933 commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Harshit933 commented Feb 2, 2025 •

edited

Loading

Harshit933 commented Feb 8, 2025 •

edited

Loading

xbjfk Apr 20, 2025 •

edited

Loading

xbjfk Apr 20, 2025 •

edited

Loading

xbjfk commented Apr 20, 2025 •

edited

Loading