Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2629 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2566 2566
Branches 651 651
=========================================
Hits 2566 2566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Because I want to validate that the regression of #2630 does not happen here, I will put this in draft |
|
I specified the target for compilation in |
|
@profnandaa if possible I want to include this in the next release as well, together with #2633 |
tux-tn
left a comment
There was a problem hiding this comment.
Thanks for the work on refreshing the old dependencies and tooling. It's really great to see progress in this area! Even though I haven’t contributed in the last few years, I’d be more than happy to help out where I can. I had tried to work on something back in #1869, but life happened and I never managed to finish it.
I also have a few suggestions and topics I’d like to raise. Do you think I should open a dedicated discussion issue for tooling, or is there already an ongoing conversation somewhere that I could join?
Regarding this PR specifically:
-
Import attributes and in particular
with { type: "json" }, aren’t supported in Node.js versions< 20.10.0. Since the Babel transpilation hook was removed from thebuild:browsercommand, this may break support for older Node.js versions. -
Node.js 24 is now the current LTS, so we probably want to add it to the CI test matrix.
Happy to discuss further and help where needed!
|
Thanks for your message!
There might be one, but that's probably quite old already so it would be good to open a new dedicated one.
I will double check, but I thought that wasn't the case because Babel is still used in the
Agreed. I didn't want to add it here before but there's no reason not to. Will update it with Node 24 |
Updates the rollup version we use and introduces a separate build step in the CI so we test on the files that will also be published to npm. This also allows us to more easily update eslint in a future PR. It's a
featbecause there might be (very) minor changes to the build itself.This incorporates part of the changes of #2401
Checklist