https://github.com/veertuinc/anka-cloud-gitlab-executor/pull/36/files\#r2499600395 fail instead of returning a problematic instance

NorseGaud · NorseGaud · commit bfc0993fd8d2 · 2025-11-06T10:50:57.000-06:00
diff --git a/internal/ankacloud/controller.go b/internal/ankacloud/controller.go
@@ -230,8 +230,9 @@ func (c *controller) GetInstanceByExternalId(ctx context.Context, externalId str
 		}
 	}
 
-	// As a last resort, return the first matching instance (could be Error/Terminated)
-	return matchingInstances[0], nil
+	// No instances in a usable state - fail explicitly instead of returning Error/Terminated instances
+	return nil, fmt.Errorf("instance with external id %s exists but is not in a usable state (found state: %s)",
+		externalId, matchingInstances[0].State)
 }
 
 func (c *controller) GetTemplateIdByName(ctx context.Context, templateName string) (string, error) {

Original file line number	Diff line number	Diff line change
`@@ -230,8 +230,9 @@ func (c *controller) GetInstanceByExternalId(ctx context.Context, externalId str`
`230`	`230`	`}`
`231`	`231`	`}`
`232`	`232`
`233`		`- // As a last resort, return the first matching instance (could be Error/Terminated)`
`234`		`- return matchingInstances[0], nil`
	`233`	`+ // No instances in a usable state - fail explicitly instead of returning Error/Terminated instances`
	`234`	`+ return nil, fmt.Errorf("instance with external id %s exists but is not in a usable state (found state: %s)",`
	`235`	`+ externalId, matchingInstances[0].State)`
`235`	`236`	`}`
`236`	`237`
`237`	`238`	`func (c *controller) GetTemplateIdByName(ctx context.Context, templateName string) (string, error) {`