Conversation
…es into invoke-expression-tx
* Added new entities for InvokeScript and InvokeExpression * Deleted a useless comment * Fixed tests and style * Deleted copies of code * Fixed tests * Fixed a very important mistake * Fixed ethereum invoke tx tests * Changed comments
nickeskov
requested changes
Feb 8, 2022
Comment on lines
+362
to
+366
| _, isEthInvokeScript := ethTx.TxKind.(*proto.EthereumInvokeScriptTxKind) | ||
| _, isEthInvokeExpression := ethTx.TxKind.(*proto.EthereumInvokeExpressionTxKind) | ||
| if !(isEthInvokeScript || isEthInvokeExpression) { | ||
| return errors.New("performing transaction was called, but the transaction is not InvokeScript or InvokeExpression") | ||
| } |
nickeskov
force-pushed
the
eth-invoke-expression-tx
branch
from
db2b705 to
2278dd8
Compare
nickeskov
requested changes
Feb 8, 2022
Comment on lines
-362
to
+366
| if _, ok := ethTx.TxKind.(*proto.EthereumInvokeScriptTxKind); ok { | ||
| if err := tp.stor.commitUncertain(info.blockID); err != nil { | ||
| return errors.Wrap(err, "failed to commit invoke changes") | ||
| } | ||
| _, isEthInvokeScript := ethTx.TxKind.(*proto.EthereumInvokeScriptTxKind) | ||
| _, isEthInvokeExpression := ethTx.TxKind.(*proto.EthereumInvokeExpressionTxKind) | ||
| if !(isEthInvokeScript || isEthInvokeExpression) { | ||
| return errors.New("performing transaction was called, but the transaction is not InvokeScript or InvokeExpression") | ||
| } |
Collaborator
There was a problem hiding this comment.
These changes break compatibility with old logic
nickeskov
added
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.