Skip to content

Conversation

@bminer
Copy link
Contributor

@bminer bminer commented Jan 2, 2025

I noted in the documentation that GetPort() only works after the Window is running (i.e. Show() has been called)... but, to be honest, I'm not sure that users will fully grasp this. One option is to return an error if webui_get_port returns 0. Thoughts?

@AlbertShown
Copy link
Member

Every time we call .show() webui use a different random port for security reason, and this port get used only when a window is started, and a web server is running. But we can set our custom port if we want.

@AlbertShown
Copy link
Member

One option is to return an error if webui_get_port returns 0. Thoughts?

Yes, we can do that 👍

@bminer bminer marked this pull request as ready for review January 6, 2025 20:07
@AlbertShown AlbertShown merged commit 41f2f2d into webui-dev:main Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants