Feature: custom wine binary path per bottle #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all I would like to thank you for your development of WineGUI. It is a really nice graphical interface on top of Wine.
Recently I came across the need for having one specific version of Wine linked to one specific bottle (wine prefix). Since WineGUI does not yet support this, I took the liberty of adding this feature myself.
In short, I added a config option to
winegui.inicalledWineBinaryPathwhich allows the user to set a specific path to a custom Wine binary. When this option is empty, the regular system Wine binary is used and WineGUI behaves as before these commits. Obviously, this path can also be changed via the GUI (see screenshots below).Furthermore, this feature should be compatible with old
winegui.inifiles where theWineBinaryPathoption is not yet present. If this option is not present, it should be detected and added towinegui.iniautomatically with an empty value (i.e. it will use the system wine binary).I tried to follow your guidelines in creating this pull request, but feel free to tell me if I did something incorrectly.
Below are some screenshots to illustrate my changes: