adding three new conection types to node SDK connection type enums#1389
Open
rarevalo13 wants to merge 1 commit intomainfrom
Open
adding three new conection types to node SDK connection type enums#1389rarevalo13 wants to merge 1 commit intomainfrom
rarevalo13 wants to merge 1 commit intomainfrom
Conversation
Contributor
Greptile OverviewGreptile SummaryAdded three new OIDC connection types (
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Enum as ConnectionType Enum
participant SDK as WorkOS SDK
participant API as WorkOS API
Dev->>Enum: Add CleverOIDC, EntraIdOIDC, OktaOIDC
Note over Enum: New connection types<br/>added to enum
SDK->>Enum: Import ConnectionType
SDK->>API: Send connection request<br/>with new type
API-->>SDK: Handle new connection types
SDK-->>Dev: Return connection response
|
| Auth0SAML = 'Auth0SAML', | ||
| AzureSAML = 'AzureSAML', | ||
| CasSAML = 'CasSAML', | ||
| CleverOIDC = 'CleverOIDC', |
Contributor
There was a problem hiding this comment.
style: Inconsistent casing: this uses OIDC (all caps) while existing AdpOidc and LoginGovOidc use Oidc (camelCase). GenericOIDC uses caps, so there's already inconsistency in the codebase.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/sso/interfaces/connection-type.enum.ts
Line: 8:8
Comment:
**style:** Inconsistent casing: this uses `OIDC` (all caps) while existing `AdpOidc` and `LoginGovOidc` use `Oidc` (camelCase). `GenericOIDC` uses caps, so there's already inconsistency in the codebase.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
There was a problem hiding this comment.
These casings match the API. Looks good
gcarvelli
approved these changes
Nov 20, 2025
| Auth0SAML = 'Auth0SAML', | ||
| AzureSAML = 'AzureSAML', | ||
| CasSAML = 'CasSAML', | ||
| CleverOIDC = 'CleverOIDC', |
Contributor
There was a problem hiding this comment.
These casings match the API. Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the following connection types:
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.