Skip to content

Update templated requirements to current releases#245

Closed
BrianHenryIE wants to merge 1 commit intowp-cli:mainfrom
BrianHenryIE:BrianHenryIE-patch-1
Closed

Update templated requirements to current releases#245
BrianHenryIE wants to merge 1 commit intowp-cli:mainfrom
BrianHenryIE:BrianHenryIE-patch-1

Conversation

@BrianHenryIE
Copy link
Member

scaffold-package-command generates a composer.json using relatively old package versions.

"require": {
"wp-cli/wp-cli": "{{require_wp_cli}}"
},
"require-dev": {
"wp-cli/wp-cli-tests": "{{require_wp_cli_tests}}"
},

This PR updates the defaults provided in the PhpDoc to the current releases:

@BrianHenryIE BrianHenryIE requested a review from a team as a code owner August 3, 2024 05:52
@ernilambar
Copy link
Member

Feature tests should also be updated.
May be we can wait for "2.11" which is going to released in a couple of days.

@BrianHenryIE
Copy link
Member Author

BrianHenryIE commented Aug 3, 2024

No urgency, but I'm not sure what exactly you're referring to with "Feature tests".

Really, the wp-cli/wp-cli update from ^2.5 to ^2.10.0 won't make a practical difference, wp-cli/wp-cli-tests from ^3.0.11 to ^4.3.1 (^4) is where I noticed an issue.

Edit: tests are failing anyway, I'll have to spend more time on this!

@ernilambar
Copy link
Member

https://github.com/wp-cli/scaffold-package-command/blob/main/features/scaffold-package-readme.feature#L43 should also be updated with new value.

@ernilambar
Copy link
Member

WP-CLI 2.11 has been released.

@swissspidy
Copy link
Member

I think I accidentally fixed this in #253, apologies for missing this PR!

@swissspidy swissspidy closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants