Update templated requirements to current releases#245
Closed
BrianHenryIE wants to merge 1 commit intowp-cli:mainfrom
Closed
Update templated requirements to current releases#245BrianHenryIE wants to merge 1 commit intowp-cli:mainfrom
BrianHenryIE wants to merge 1 commit intowp-cli:mainfrom
Conversation
Member
|
Feature tests should also be updated. |
Member
Author
|
No urgency, but I'm not sure what exactly you're referring to with "Feature tests". Really, the wp-cli/wp-cli update from Edit: tests are failing anyway, I'll have to spend more time on this! |
Member
|
https://github.com/wp-cli/scaffold-package-command/blob/main/features/scaffold-package-readme.feature#L43 should also be updated with new value. |
Member
|
WP-CLI |
Member
|
I think I accidentally fixed this in #253, apologies for missing this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scaffold-package-commandgenerates acomposer.jsonusing relatively old package versions.scaffold-package-command/templates/composer.mustache
Lines 8 to 13 in c309cf5
This PR updates the defaults provided in the PhpDoc to the current releases: