Adding automatic module name header (#713)

[gunnarmorling]

Hey @xerial, this change adds an automatic module name header to the JAR manifest, i.e. when using snappy-java as an automatic module with a modularized Java application (JPMS), org.xerial.snappy is going to be its module name. By defining this name, other libraries depending on snappy-java can be distributed as JPMS modules to Maven Central.

I have successfully tested using snappy-java in a modularized Java application, using the name defined in the header.

[gemini-code-assist]

Summary of Changes

Hello @gunnarmorling, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the snappy-java library's compatibility with the Java Platform Module System (JPMS). By defining an explicit automatic module name, it streamlines the integration of snappy-java into modular Java applications, making it easier for other JPMS-compliant libraries to declare dependencies on it.

Highlights

• Java Module System (JPMS) Support: This pull request introduces an Automatic-Module-Name header to the JAR manifest, explicitly setting the module name to org.xerial.snappy. This change enables snappy-java to be consumed as an automatic module within modularized Java applications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds the Automatic-Module-Name to the JAR manifest, which is an important step for compatibility with the Java Platform Module System (JPMS). The change is a valuable addition. I have one suggestion to improve the maintainability of the sbt build file by avoiding a hardcoded value.

[gemini-code-assist]

To improve maintainability and promote the DRY (Don't Repeat Yourself) principle, it's better to reuse the existing organization setting rather than hardcoding the module name. This ensures the module name remains consistent with the organization identifier.

packageOptions += Package.ManifestAttributes("Automatic-Module-Name" -> organization.value)