Fix Sentry package bugs: name mismatch and FAT static detection #198
+74
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130
Problem
Framework name mismatch:
Sentry-Dynamic.xcframeworkcontainsSentry.framework, but xtool looked forSentry-Dynamic.frameworkFAT static detection: FAT binaries (
0xCAFEBABE) containing static archive slices were misidentified as dynamicSolution
Added
findFrameworkName()to scan binDir when expected framework name doesn't exist, matching by binary header or prefixEnhanced
isStaticBinary()to parse FAT headers and check slice magic (!<arch>\n) instead of just checking outer magicVerification
Test Plan
Linux
isStaticBinary()- correctly identifies static vs dynamicfindFrameworkName()- resolvesSentry-Dynamic→SentrymacOS
Sentry.frameworkinsideSentry-Dynamic.xcframework)