fix: (AES audit) add redundant range constraints when AES, ACIR opcode is not generated by Noir #20125
+345
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added md explaining the flow + a bit of renaming
Primary changes: - Replace methods of the form `get_*_gate_connected_component` with `GatePattern` structs that specify the conditions under which each wire is constrained for each gate type - Test correctness of `GatePattern`'s by perturbing relation inputs to empirically check which wires are constrained (`gate_patterns.test.cpp`) - Resolves a few bugs/errors identified by the aforementioned tests (see PR comments) - Use `update_used_witnesses` in `fix_witness` to avoid need for ad-hoc handling in the tooling Cleanup: - Replace use of `block_idx` with reference to `block` in several places for improved clarity --------- Co-authored-by: Claude Opus 4.5 <[email protected]>
kashbrti
changed the title
kashbrti
force-pushed
the
kb/aes_audit_add_range_constraints
branch
from
ae56c16 to
82050ed
Compare
…ztec-packages into merge-train/barretenberg
johnathan79717
pushed a commit
that referenced
this pull request
Feb 4, 2026
…e is not generated by Noir (#20125) add redundant range constraints when AES, ACIR opcode is not generated by Noir --------- Co-authored-by: sergei iakovenko <[email protected]> Co-authored-by: ledwards2225 <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> Co-authored-by: AztecBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add redundant range constraints when AES, ACIR opcode is not generated by Noir