feat(avm)!: smaller precomputed trace#20144
Conversation
fcarreiro
left a comment
There was a problem hiding this comment.
I have some doubts about the PIL changes. I think that only lookups into precomputed or PIs should use idx. Shouldn't the rest use the execution clk? In particular think of memory. In simulation the clk manager (or whatever the name was) links it to execution.
barretenberg/cpp/src/barretenberg/vm2/tracegen/precomputed_trace.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/tracegen/precomputed_trace.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/tracegen/precomputed_trace.hpp
Outdated
Show resolved
Hide resolved
@fcarreiro You are absolutely right. I think I overlooked the virtual trace of execution. I will review all of these changes more carefully. |
18b28ac to
82d36b4
Compare
82d36b4 to
8d4560e
Compare
|
@federicobarbacovi @iakovenkos Could you please have a look at the changes in the files: prover.cpp, verifier.cpp, recursive_verifier.cpp? |
barretenberg/cpp/src/barretenberg/vm2/tracegen/precomputed_trace.test.cpp
Outdated
Show resolved
Hide resolved
federicobarbacovi
left a comment
There was a problem hiding this comment.
Looks good to me!
8d4560e to
10c9a13
Compare
BEGIN_COMMIT_OVERRIDE feat(avm)!: smaller precomputed trace (#20144) END_COMMIT_OVERRIDE
This PR performs the following changes (kudo to @fcarreiro for suggesting this):
Performance improvements
3sto ~1.3son 32 cores.