Skip to content

Conversation

@jason-vasilev
Copy link
Contributor

Saw a 404 link in Foundation final project for Flipping Card game where it says "which you can find here"

Seemed like we were getting a README file in the link through the build process, as before that, it was not in the source code. Didn't know how to fix it, so instead just made a file that embeds the assets

Copy link
Contributor

@shpomp shpomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! ⭐

#### The Flippable Card

You are provided with a card picture and a card backside image which you can use, [which you can find here](./assets/card/), or feel free to choose your own.
You are provided with a card picture and a card backside image which you can use, [which you can find here](./assets/card/README.md), or feel free to choose your own.
Copy link
Contributor

@shpomp shpomp Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what sense it makes to provide a card picture, as they will have to find more on their own anyway and might want to choose a theme themselves - so I think this should be corrected.
Perhaps we can then just give a short comment and link to the backside pattern itself?

Suggested change
You are provided with a card picture and a card backside image which you can use, [which you can find here](./assets/card/README.md), or feel free to choose your own.
Find a few pictures to use for your game. Consider if you would use random images or make your game themed.
Use [this](./assets/card/card-backside.jpg) card backside image, or find/create your own.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because the first exercise is focussed on just making it flippable, it's nice to give them two assets to get started with asap. We do write that they are free to choose their own. You're right they will have to find their own later anyway, i think it's ok to leave it up to them then.

I am not in the session though, if it was not so smooth in the session i'm happy to leave it up to you/mentors who saw it in action :-)

@@ -0,0 +1,5 @@
Card Backside
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jason-vasilev! I am not sure how the readme link ended up here, I think it was just a mistake by me when i moved it all into the new program.

Linting fails because every readme needs a H1 at the top. I added it below, if you commit it the linting should pass 🤞 .

I will approve/merge once it passes, unless other comments are unresolved.

Suggested change
Card Backside
# Initial Card Assets
Card Backside

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

4 participants