Skip to content

Fix 404 link though adding a README file #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jason-vasilev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix 404 link though adding a README file #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dbc5a1
Add missing README and embed assets in it
jason-vasilev Feb 1, 2026
878ea72
Add Readme explicitely to the link now
jason-vasilev Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions courses/foundation/final-project/assets/card/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Card Backside
Copy link
Contributor

@adamblanchard adamblanchard Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jason-vasilev! I am not sure how the readme link ended up here, I think it was just a mistake by me when i moved it all into the new program.

Linting fails because every readme needs a H1 at the top. I added it below, if you commit it the linting should pass 🤞 .

I will approve/merge once it passes, unless other comments are unresolved.

Suggested change
Card Backside
# Initial Card Assets
Card Backside

![Card Backside](card-backside.jpg)

Card Picture
![Card Picture](card-picture.jpg)
2 changes: 1 addition & 1 deletion courses/foundation/final-project/project-brief.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ You are strongly encouraged to add your own features, details, design and flare

#### The Flippable Card

You are provided with a card picture and a card backside image which you can use, [which you can find here](./assets/card/), or feel free to choose your own.
You are provided with a card picture and a card backside image which you can use, [which you can find here](./assets/card/README.md), or feel free to choose your own.
Copy link
Contributor

@shpomp shpomp Feb 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what sense it makes to provide a card picture, as they will have to find more on their own anyway and might want to choose a theme themselves - so I think this should be corrected.
Perhaps we can then just give a short comment and link to the backside pattern itself?

Suggested change
You are provided with a card picture and a card backside image which you can use, [which you can find here](./assets/card/README.md), or feel free to choose your own.
Find a few pictures to use for your game. Consider if you would use random images or make your game themed.
Use [this](./assets/card/card-backside.jpg) card backside image, or find/create your own.

Copy link
Contributor

@adamblanchard adamblanchard Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because the first exercise is focussed on just making it flippable, it's nice to give them two assets to get started with asap. We do write that they are free to choose their own. You're right they will have to find their own later anyway, i think it's ok to leave it up to them then.

I am not in the session though, if it was not so smooth in the session i'm happy to leave it up to you/mentors who saw it in action :-)

Copy link
Contributor

@shpomp shpomp Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, thanks for explaining @adamblanchard!
I created this, I should have remembered :D


Your app needs to:

Expand Down
Loading