-
Notifications
You must be signed in to change notification settings - Fork 8
Tests: Import: AWeber #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
| * | ||
| * @since 3.1.5 | ||
| */ | ||
| public function testGetAWeberFormIDsFromContent() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you moved this to the parent class, it makes more sense to name the test at that level, so testGetGenericFormIDsFromContent vs. naming to the specific provider. I also don't see the value of testGetMC4WPFormIDsFromContent since you're exercising the same code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep these, as they test using the ConvertKit_Admin_Importer_AWeber / ConvertKit_Admin_Importer_MC4WP classes, ensuring only the applicable shortcodes are extracted i.e. AWeber shortcodes when using ConvertKit_Admin_Importer_AWeber and Mailchimp shortcodes when using `ConvertKit_Admin_Importer_MC4WP.
I've improved the tests to ensure other shortcodes aren't extracted, which hopefully means having two separate tests makes more sense here.
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
Summary
Adds tests for #991
Testing
Existing tests pass.
Checklist